You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
RequestSequence is very picky about types of arguments, but lacks any checking or coercion. For example, in the request tuple:
b'get' vs. 'get'—the former is required
b'get' vs. 'GET'—the former is required
The URL is str, but everything else must be bytes
If you pass the wrong type, the request sequence will not ever match. I'd say we should blacklist str where bytes is required and vice-versa. (Blacklist rather than whitelist because the ability to pass fuzzy matchers like HasHeaders is useful.)
RequestSequence is very picky about types of arguments, but lacks any checking or coercion. For example, in the request tuple:
b'get'
vs.'get'
—the former is requiredb'get'
vs.'GET'
—the former is requiredstr
, but everything else must bebytes
If you pass the wrong type, the request sequence will not ever match. I'd say we should blacklist
str
wherebytes
is required and vice-versa. (Blacklist rather than whitelist because the ability to pass fuzzy matchers likeHasHeaders
is useful.)In the response tuple:
And generally speaking, writing out these tuples is easy to botch. Perhaps we should add a builder API to make it easier?
The text was updated successfully, but these errors were encountered: