Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please publish for Scala 2.13.14 #278

Closed
SethTisue opened this issue Apr 29, 2024 · 8 comments
Closed

Please publish for Scala 2.13.14 #278

SethTisue opened this issue Apr 29, 2024 · 8 comments
Assignees

Comments

@SethTisue
Copy link
Member

...which is now on Maven Central, as per https://contributors.scala-lang.org/t/scala-2-13-14-release-planning/6581/13

@rossabaker
Copy link
Member

I tried with the back-publish script, but ran into java.lang.NoClassDefFoundError: Could not initialize class sbt.internal.parser.SbtParser$.

@armanbilge armanbilge self-assigned this Apr 30, 2024
@armanbilge
Copy link
Member

@TonioGela
Copy link
Member

I tried with the back-publish script, but ran into java.lang.NoClassDefFoundError: Could not initialize class sbt.internal.parser.SbtParser$.

FWIW this happens to me when using JDK21 with an old version of sbt. If you update to 1.10.x it should be good to go.

@SethTisue
Copy link
Member Author

If you update to 1.10.x it should be good to go

PR: #281

@rossabaker
Copy link
Member

That's helpful, but the old version of SBT is in the tag that we are backpublishing from. 0.13.3 caused a lot toil downstream, so there's a lot of value in avoiding a 0.13.4. Right now, the only impure thing about backpublishing is providing $SCALA_VERSION as an argument to the script. I don't see a way to upgrade SBT without a new tag or brazen irreproducibility.

Next time, we could tag a v0.13.3_2.13.15 or some such, and have that include #281. That would knock off the bitrot, not make filthy liars of us, and still produce a 0.13.3. My fear there is that tag format interfering with some other tooling.

Alternatively, we can be more careful to use jdk8. That's what the flake.nix is all about, and I must have overlooked direnv screeching at me that I was on a new machine. And then #281 is there on main for whatever future problem triggers 0.13.4.

@SethTisue
Copy link
Member Author

fwiw, in my own repos elsewhere, I often backpublish from HEAD rather than from the actual tag if I look at the diffs since the tag and I can see that the only things that have been merged since the tag are immaterial-to-the-end-user things like the sbt version.

This may make me a "filthy liar" :-)

@rossabaker
Copy link
Member

My problem with that is it's hard to nail down what's "immaterial". Which Scala 2.13 something was built with used to be immaterial. And then, before bidirectional compatibility is broken, a Scala patch version in a dependency may now manifest as a warning in the latest SBT. That was a good change in SBT, to insulate us against the more severe breakage that is to come. But it is also something that retroactively became material.

Since this plugin is fully cross-built, even that particular change is immaterial to this project, but it underscores why I'm squeamish any divergence from the tag.

@armanbilge
Copy link
Member

Alternatively, we can be more careful to use jdk8.

Mm, yes. I was following the release instructions in the README which is why I didn't have that problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants