Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specificly clone git branch and revision or bail out on MIG_GIT_REV mismatch #68

Open
jonasbardino opened this issue Jun 13, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@jonasbardino
Copy link
Contributor

During build we currently make a git clone followed first by a git checkout of the branch (MIG_GIT_BRANCH) and second a git checkout of the revision (MIG_GIT_REV). While that sort of works for the general case it has the annoying side effect that if a revision not on the chosen branch is given as MIG_GIT_REV it will effectively silently switch to the corresponding branch and revision. That becomes particularly confusing when using python3-only containers where the experimental branch is currently strictly required, because it will then lead to confusing build errors e.g. when python3 is applied to the python2-only configuration generator.
We should look into a better way to pick exactly the right branch and revision or add a simple test to bail out early if MIG_GIT_BRANCH and MIG_GIT_REV don't match up.

@jonasbardino jonasbardino added bug Something isn't working enhancement New feature or request labels Jun 13, 2024
@jonasbardino jonasbardino added this to the Rocky9 Deployments milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant