You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
what is a processingPhaseTag2. In fact, we need to add good docs related to this tag and digest stuff. I mean, with some examples. This is non-trivial stuff (so, need proper doc).
As I commented before, the code you added looks good to me but we need to refactor legacy code:
remove silly documentation (e.g. "This function adds new user." in a method called addNewUserInCatalog does not add much, so remove the setence)
remove dead code
overall, we have important code in classes name *Util (e.g. CatalogUtils) and ancillary code in the main classes (e.g. formatPathRow)
what is a
processingPhaseTag2
. In fact, we need to add good docs related to this tag and digest stuff. I mean, with some examples. This is non-trivial stuff (so, need proper doc).As I commented before, the code you added looks good to me but we need to refactor legacy code:
addNewUserInCatalog
does not add much, so remove the setence)Originally posted by @thiagomanel in #59
The text was updated successfully, but these errors were encountered: