Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SubmissionDispatcher class #74

Open
thiagoyeds opened this issue Jan 28, 2020 · 0 comments
Open

Refactor SubmissionDispatcher class #74

thiagoyeds opened this issue Jan 28, 2020 · 0 comments

Comments

@thiagoyeds
Copy link
Contributor

thiagoyeds commented Jan 28, 2020

what is a processingPhaseTag2. In fact, we need to add good docs related to this tag and digest stuff. I mean, with some examples. This is non-trivial stuff (so, need proper doc).

As I commented before, the code you added looks good to me but we need to refactor legacy code:

  1. remove silly documentation (e.g. "This function adds new user." in a method called addNewUserInCatalog does not add much, so remove the setence)
  2. remove dead code
  3. overall, we have important code in classes name *Util (e.g. CatalogUtils) and ancillary code in the main classes (e.g. formatPathRow)

Originally posted by @thiagomanel in #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant