Skip to content

Commit 6d290ad

Browse files
subkrishromani
authored andcommittedAug 1, 2017
Issue checkstyle#4592: Added AbstractPathTestSupport, AbstractModuleTestSupport, AbstractIndentationTestSupport and all tests in ITs extend them
1 parent 29e131f commit 6d290ad

File tree

61 files changed

+283
-464
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+283
-464
lines changed
 

‎config/checkstyle_checks.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,9 @@
101101
</module>
102102
<module name="RegexpOnFilename">
103103
<property name="folderPattern" value="[\\/]src[\\/]it[\\/]java[\\/]"/>
104-
<property name="fileNamePattern" value="^((\w+Test)|(Base\w+))\.java$"/>
104+
<property name="fileNamePattern" value="^((\w+Test)|(Abstract\w+))\.java$"/>
105105
<property name="match" value="false"/>
106-
<message key="regexp.filepath.mismatch" value="All files in the ''src/it/java'' folder should be named ''*Test.java'' or ''Base*.java''."/>
106+
<message key="regexp.filepath.mismatch" value="All files in the ''src/it/java'' folder should be named ''*Test.java'' or ''Abstract*.java''."/>
107107
</module>
108108

109109
<!-- Size Violations -->

‎config/intellij-idea-inspections.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2204,7 +2204,7 @@
22042204
<inspection_tool class="TestMethodInProductCode" enabled="true" level="ERROR" enabled_by_default="true" />
22052205
<inspection_tool class="TestMethodIsPublicVoidNoArg" enabled="true" level="ERROR" enabled_by_default="true" />
22062206
<inspection_tool class="TestMethodWithoutAssertion" enabled="true" level="ERROR" enabled_by_default="true">
2207-
<option name="assertionMethods" value="org.junit.Assert,assert.*|fail.*,junit.framework.Assert,assert.*|fail.*,org.mockito.Mockito,verify.*,org.mockito.InOrder,verify,org.junit.rules.ExpectedException,expect.*,org.hamcrest.MatcherAssert,assertThat,com.puppycrawl.tools.checkstyle.BaseCheckTestSupport,verify.*,com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport,verify.*,com.puppycrawl.tools.checkstyle.AbstractTreeTestSupport,verify.*,com.google.checkstyle.test.base.BaseCheckTestSupport,verify.*,com.puppycrawl.tools.checkstyle.internal.TestUtils,assert.*,com.puppycrawl.tools.checkstyle.grammars.AstRegressionTest.AssertGeneratedJavaLexer,verify.*,nl.jqno.equalsverifier.EqualsVerifier,verify.*,org.powermock.api.mockito.PowerMockito,verify.*" />
2207+
<option name="assertionMethods" value="org.junit.Assert,assert.*|fail.*,junit.framework.Assert,assert.*|fail.*,org.mockito.Mockito,verify.*,org.mockito.InOrder,verify,org.junit.rules.ExpectedException,expect.*,org.hamcrest.MatcherAssert,assertThat,com.puppycrawl.tools.checkstyle.BaseCheckTestSupport,verify.*,com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport,verify.*,com.puppycrawl.tools.checkstyle.AbstractTreeTestSupport,verify.*,com.google.checkstyle.test.base.AbstractModuleTestSupport,verify.*,com.puppycrawl.tools.checkstyle.internal.TestUtils,assert.*,com.puppycrawl.tools.checkstyle.grammars.AstRegressionTest.AssertGeneratedJavaLexer,verify.*,nl.jqno.equalsverifier.EqualsVerifier,verify.*,org.powermock.api.mockito.PowerMockito,verify.*" />
22082208
<option name="assertKeywordIsAssertion" value="false" />
22092209
</inspection_tool>
22102210
<inspection_tool class="TestNGDataProvider" enabled="true" level="ERROR" enabled_by_default="true" />

0 commit comments

Comments
 (0)