New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular Spline Mapping #133

Closed

behinger opened this issue Oct 13, 2022 · 1 comment

Member

behinger commented Oct 13, 2022

The circular spline mapValues function is broken. A modulo was wrongfully commented out, where it should have been included.

This happens in two places and needs to be fixed

behinger closed this as completed in

3299c37

behinger added a commit that referenced this issue


          bugfix map_value fixes 2 #133

ff0c7fc

Member Author

behinger commented Oct 13, 2022

this pertains to all analyses with cyclical splines AND values outside the upper/lower bounds.

E.g. if you did spl_cic([0,180,360,520],0,360), then the 520 was not wrapped down to 160°!

if all your values were within the given bounds, everything worked correctly. If you did not specify bounds, everything worked correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment