refactoring of graph editor

Author: oleghcp

Code/Editor/Window/GraphEditorWindow.cs

@@ -31,7 +31,7 @@ internal class GraphEditorWindow : EditorWindow
         public int OnGuiCounter => _onGuiCounter;
         public GraphCamera Camera => _camera;
         public bool GridSnapping => _toolbar.GridToggle;
-        public TransitionViewType TransitionView => _toolbar.TransitionView;
+        public bool ShowPorts => _toolbar.ShowPorts;
         public GraphEditorSettings Settings => _settings;
         public GraphMap Map => _map;
         public bool FullDrawing => !_toolbar.HideContentToggle;

Code/Editor/Window/NodeBased/GraphMap.cs

@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Reflection;
-using System.Runtime.CompilerServices;
 using OlegHcp;
 using OlegHcp.CSharp;
 using OlegHcp.CSharp.Collections;
@@ -272,20 +271,15 @@ private void DrawConnectionLine(Event e)
             if (_selectedPort == null)
                 return;
 
-            switch (_window.TransitionView)
+            if (_window.ShowPorts)
             {
-                case TransitionViewType.Splines:
-                    Vector2 startTangentDir = _selectedPort.Type == PortType.In ? Vector2.left : Vector2.right;
-                    Vector2 endTangentDir = _selectedPort.Type == PortType.In ? Vector2.right : Vector2.left;
-                    TransitionViewer.DrawSpline(_selectedPort.ScreenRect.center, e.mousePosition, startTangentDir, endTangentDir);
-                    break;
-
-                case TransitionViewType.Arrows:
-                    TransitionViewer.DrawDirection(_selectedPort.Node.ScreenRect.center, e.mousePosition);
-                    break;
-
-                default:
-                    throw new SwitchExpressionException(_window.TransitionView);
+                Vector2 startTangentDir = _selectedPort.Type == PortType.In ? Vector2.left : Vector2.right;
+                Vector2 endTangentDir = _selectedPort.Type == PortType.In ? Vector2.right : Vector2.left;
+                TransitionViewer.DrawSpline(_selectedPort.ScreenRect.center, e.mousePosition, startTangentDir, endTangentDir);
+            }
+            else
+            {
+                TransitionViewer.DrawDirection(_selectedPort.Node.ScreenRect.center, e.mousePosition);
             }
 
             GUI.changed = true;

Code/Editor/Window/NodeBased/GraphToolbar.cs

@@ -40,7 +40,7 @@ internal class GraphToolbar
         public bool HideContentToggle => _hideContentToggle;
         public bool SidePanelToggle => _sidePanelToggle;
         public bool GridToggle => _gridSnapToggle;
-        public TransitionViewType TransitionView => (TransitionViewType)_transitionViewType;
+        public bool ShowPorts => _transitionViewType == (int)TransitionViewType.Splines;
 
         public GraphToolbar(GraphEditorWindow window)
         {

Code/Editor/Window/NodeBased/NodeDrawing/NodeViewer.cs

@@ -216,7 +216,7 @@ public void Draw()
 
             void drawPorts()
             {
-                if (_window.TransitionView == TransitionViewType.Splines)
+                if (_window.ShowPorts)
                 {
                     if (_type != NodeType.Common) _in.Draw();
                     if (_type != NodeType.Exit) _out.Draw();
@@ -226,24 +226,19 @@ void drawPorts()
 
         public void DrawTransitions()
         {
-            switch (_window.TransitionView)
+            if (_window.ShowPorts)
             {
-                case TransitionViewType.Splines:
-                    for (int i = 0; i < _transitionViewers.Count; i++)
-                    {
-                        _transitionViewers[i].DrawSpline();
-                    }
-                    break;
-
-                case TransitionViewType.Arrows:
-                    for (int i = 0; i < _transitionViewers.Count; i++)
-                    {
-                        _transitionViewers[i].DrawArrow();
-                    }
-                    break;
-
-                default:
-                    throw new SwitchExpressionException(_window.TransitionView);
+                for (int i = 0; i < _transitionViewers.Count; i++)
+                {
+                    _transitionViewers[i].DrawSpline();
+                }
+            }
+            else
+            {
+                for (int i = 0; i < _transitionViewers.Count; i++)
+                {
+                    _transitionViewers[i].DrawArrow();
+                }
             }
         }
 
@@ -360,7 +355,7 @@ private void ProcessContextMenu()
             Vector2 clickPosition = Event.current.mousePosition;
             GenericMenu genericMenu = new GenericMenu();
 
-            bool arrows = _window.TransitionView == TransitionViewType.Arrows;
+            bool arrows = !_window.ShowPorts;
             string addTransition = "Add Transition";
             string delete = "Delete";
             string info = "Info";