Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter emails by domain, api keys #37

Open
KMKoushik opened this issue Jul 24, 2024 · 16 comments
Open

Filter emails by domain, api keys #37

KMKoushik opened this issue Jul 24, 2024 · 16 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@KMKoushik
Copy link
Member

  • Domain is easy, we already have a field "domainId" in email table.
  • For api key need to add new field apiId to email table. No need of foreign key!
Screenshot 2024-07-25 at 7 21 39 am
@KMKoushik KMKoushik added enhancement New feature or request good first issue Good for newcomers labels Jul 24, 2024
@pravo23
Copy link

pravo23 commented Jul 25, 2024

Hi, I want to work on this

@KMKoushik
Copy link
Member Author

@pravo23 thank you for the interest. i have assigned it you. lemme know if you need any help. also join the discord server so i can answer if you have any questions

@KMKoushik
Copy link
Member Author

@pravo23 lemme know if you need any help on this, you can ping in the discord as well. happy to help

@pravo23 pravo23 removed their assignment Aug 3, 2024
@pravo23
Copy link

pravo23 commented Aug 3, 2024

Hi, sorry for late update. but I am not working on the issue due to my unavailability. Apologies

@KMKoushik
Copy link
Member Author

No issues!

@Mihan786Chistie
Copy link

@KMKoushik I would like to work on this issue, please assign it to me

@KMKoushik
Copy link
Member Author

@Mihan786Chistie Thank you assigned to you

@Mihan786Chistie
Copy link

Hey @KMKoushik, shouldn't the domainId in the Email table have a relation with the Domain table? It's just showing as an Int

image

@KMKoushik
Copy link
Member Author

@Mihan786Chistie not necessarily, it slows insert and update.

@Mihan786Chistie
Copy link

So the domainId can be added when an email is created but not necessarily linked?

@KMKoushik
Copy link
Member Author

linked in via code logic just not verified by sql server

@Mihan786Chistie
Copy link

Hey @KMKoushik sorry I was having my exams wasn't able to contribute, will try to look into it now

@Surajsuthar
Copy link

@KMKoushik can i try ?

@KMKoushik
Copy link
Member Author

@Surajsuthar yep give it a try!

sorry @Mihan786Chistie! since there's no progress, i'm going to let suraj to give a try

@Mihan786Chistie
Copy link

@Surajsuthar yep give it a try!

sorry @Mihan786Chistie! since there's no progress, i'm going to let suraj to give a try

No problem, been busy a bit lately

@KMKoushik
Copy link
Member Author

that's all right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants