Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UidlWriter().write() outside of VaadinServletService.requestStart and requestEnd #11149

Open
lelmarir opened this issue Aug 29, 2018 · 1 comment

Comments

@lelmarir
Copy link

in com.vaadin.server.communication.AtmospherePushConnection the method push will call new UidlWriter().write(getUI(), writer, async); that in turn will call all the connectors and any beforeClientResponse

all this will happen on a new web socket connection (and thus still a normal HTTP request)

I'm using VaadinServletService.requestStart and VaadinServletService.requestEnd to initialize and destroy some connections, and the fact that some beforeClientResponse will be triggered outsinde of these is causing troubles.

Is it possible to call VaadinServletService.requestStart and VaadinServletService.requestEnd also around the websocket connection?

Vaadin version: 8.3.3

@stale
Copy link

stale bot commented Jan 28, 2019

Hello there!

We are sorry that this issue hasn't progressed lately. We are prioritizing issues by severity and the number of customers we expect are experiencing this and haven't gotten around to fix this issue yet.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Jan 28, 2019
@stale stale bot removed Stale Stale bot label labels Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants