Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future-Proof ValkeyModuleScriptingEngineGetMemoryInfoFunc by Requiring Caller-Allocated Info Buffer with Provided Size #1469

Open
PingXie opened this issue Dec 22, 2024 · 3 comments
Open

Future-Proof ValkeyModuleScriptingEngineGetMemoryInfoFunc by Requiring Caller-Allocated Info Buffer with Provided Size #1469

PingXie opened this issue Dec 22, 2024 · 3 comments
Assignees
@rjd15372

Comments

@PingXie
Copy link
Member

PingXie commented Dec 22, 2024 

          the info buffer needs be allocated by the caller with size provided for future-proofing. see `ValkeyModule_GetClientInfoById`

Originally posted by @PingXie in #1277 (comment)
@PingXie
Copy link
Member Author

PingXie commented Dec 22, 2024

FYI @rjd15372

@rjd15372
Copy link
Contributor

@PingXie @zuiderkwast can one of you assign this issue to me?

@PingXie
Copy link
Member Author

PingXie commented Dec 24, 2024

@rjd15372, your name showed up now. I've assigned it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjd15372 rjd15372

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rjd15372 @PingXie