-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Genome builds have no unified format #408
Comments
Issue is that currently the type definition for the seqvar/structvar endpoints are defined in rust, whereas the tx endpoint is directly defined in protobuf. All exposed API endpoints should be defined consistently. Putting query definitions in protobuf might have the nice effect for allowing non-http APIs, but might be less easy to use in rust. |
Currently prost is used to interface with protobuf defined structures, whereas everything else uses serde. Both are unfortunately not compatible. As a general design, moving everything i/o facing into protobuf might make sense. |
Action plan
|
With utoipa, openAPI schema and corresponding new |
Describe the bug
Currently genome builds have different "names"/"labels" in different APIs. For example:
https://reev.cubi.bihealth.org/internal/proxy/mehari/genes/txs?hgncId=HGNC:4806&genomeBuild=GENOME_BUILD_GRCH37&pageSize=1000
https://reev.cubi.bihealth.org/internal/proxy/mehari/seqvars/csq?genome_release=grch37&chromosome=6&position=24302274&reference=T&alternative=C
To Reproduce
N/A
Expected behavior
There should be one standard for genome builds across the mehari APIs.
Additional context
N/A
The text was updated successfully, but these errors were encountered: