Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT mutations across multiple segments #562

Open
atc3 opened this issue Jul 25, 2022 · 0 comments
Open

NT mutations across multiple segments #562

atc3 opened this issue Jul 25, 2022 · 0 comments
Labels
data enhancement New feature or request UI User Interface viz Data Visualization

Comments

@atc3
Copy link
Member

atc3 commented Jul 25, 2022

The custom coordinates mode is currently being adapted in the Flu version to accommodate segment information (this is not relevant in the SARS2 and RSV sites where only one segment is present). While querying for and parsing mutations from multiple segments is not an issue (and has been tested), there are a couple of problems (listed below). To avoid these problems currently, we are restricting mutations to cover at most one segment (multiple segments not allowed), and to support more than one segment would require some fixes:

  1. The entropy plot (mutation frequency plot) only supports one linear stretch of mutations. If querying for mutations along multiple segments, i.e., positions 1–100 on segment 1 and 1–100 on segment 2, then mutations from both segments will be overlaid onto the same plot, resulting in a misleading graphic. Solutions for this:

    • Make multiple entropy plots and arrange them horizontally, one plot for each segment. This is possible but would require some Vega trickery plus smart horizontal scaling
    • Make multiple entropy plots, but arrange them vertically. Pass as props into the Entropy plot which segment that plot covers, and inside each Entropy plot component, filter for mutations for that segment (preferred solution)
  2. Coverage data is currently designed for one continuous linear segment. Querying over multiple segments produces incorrect coverage data. Segment-aware coverage would require a rewrite of the coverage logic and the addition of a segment field into the returned coverage data -- either separate coverage data arrays for each segment, or a segment identifier within each coverage entry. The frontend would then need to parse this and each visualization would need changes to parse this new form of data

@atc3 atc3 added enhancement New feature or request UI User Interface data viz Data Visualization labels Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data enhancement New feature or request UI User Interface viz Data Visualization
Projects
None yet
Development

No branches or pull requests

1 participant