Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping querystring items out of URL path #12

Open
fprati opened this issue Jul 23, 2018 · 3 comments
Open

Keeping querystring items out of URL path #12

fprati opened this issue Jul 23, 2018 · 3 comments

Comments

@fprati
Copy link

fprati commented Jul 23, 2018

Same as ventrian/Property-Agent#5

@skamphuis
Copy link
Collaborator

Can you be more specific on what is wrong/needs to be fixed and why?

@fprati
Copy link
Author

fprati commented Oct 24, 2018

Hi,
as explained in the equivalent PA issue, the module seems to rewrite the querystrings containing '?' and replacing it with a '/'. I think it is something in the module because pages not containing the NA or PA would behave correctly, assuming one modifies the website regex.
The consequence is that one cannot rely on adwords stats for PA/NA generated pages as those would be unreliable/false.
To prove it, just go on a NA page and add ?gclid=whatever tothe URL and you will see it rewritten immediately with '/'.

@skamphuis
Copy link
Collaborator

To be honest, I don't think it's NA that's rewriting a URL. I tested it on a 8.0.4 installation and can see that behavior, but it's on every page, not only NA ones. On my 9.2.2 installation the querystring parameter just stays in the original format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants