Skip to content

Commit 01bd720

Browse files
committed
fix strcmp and move developper relative instruction
1 parent 0862af4 commit 01bd720

File tree

4 files changed

+21
-13
lines changed

4 files changed

+21
-13
lines changed

ODIN_II/verify_full.sh

100644100755
File mode changed.

README.developers.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,3 +154,23 @@ You may need to configure coverity to 'know' about your compiler. For example:
154154
```shell
155155
cov-configure --compiler `which gcc-7`
156156
```
157+
158+
Debugging with clang static analyser
159+
------------------------------------
160+
First make sure you have clang installed.
161+
define clang as the default compiler:
162+
`export CC=clang`
163+
`export CXX=clang++`
164+
165+
set to `debug` in makefile
166+
167+
On unix-like systems run `scan-build make` from the root VTR directory.
168+
to output the html analysis to a specific folder, run `scan-build make -o /some/folder`
169+
170+
Commit with changes on ODIN
171+
---------------------------
172+
make sure all test passes:
173+
microbechmark, full regression an vtr strong regression test.
174+
175+
ODIN_II/verify_full.sh takes care of running all of them at once.
176+
verify they are all successfull.

README.md

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,6 @@ On unix-like systems run `make` from the root VTR directory.
2626

2727
For more details see [here](BUILDING.md).
2828

29-
Development Debugging
30-
========
31-
First make sure you have clang installed.
32-
define clang as the default compiler:
33-
`export CC=clang`
34-
`export CXX=clang++`
35-
36-
set to `debug` in makefile
37-
38-
On unix-like systems run `scan-build make` from the root VTR directory.
39-
to output the html analysis to a specific folder, run `scan-build make -o /some/folder`
40-
4129
Docker Cloud9 Deployment
4230
========================
4331
We provide a Dockerfile that sets up all the necessary packages for VTR to run. Also, the Dockerfile sets up Cloud9, a workspace management system that runs on your browser and allows you to run (and modify) VTR remotely.

libvtrutil/src/vtr_util.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ std::vector<std::string> ReadLineTokens(FILE * InFile, int *LineNum) {
410410

411411
int strcmp(const char* first, const char* second){
412412
if(first && second){
413-
return strncmp(first, second, vtr::BUFSIZE);
413+
return strncmp(first, second, vtr::bufsize);
414414
}else{
415415
return -1;
416416
}

0 commit comments

Comments
 (0)