Skip to content

Commit

Permalink
fix strcmp and move developper relative instruction
Browse files Browse the repository at this point in the history
  • Loading branch information
jeanlego committed Jun 8, 2017
1 parent 0862af4 commit 01bd720
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 13 deletions.
Empty file modified ODIN_II/verify_full.sh
100644 → 100755
Empty file.
20 changes: 20 additions & 0 deletions README.developers.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,3 +154,23 @@ You may need to configure coverity to 'know' about your compiler. For example:
```shell
cov-configure --compiler `which gcc-7`
```

Debugging with clang static analyser
------------------------------------
First make sure you have clang installed.
define clang as the default compiler:
`export CC=clang`
`export CXX=clang++`

set to `debug` in makefile

On unix-like systems run `scan-build make` from the root VTR directory.
to output the html analysis to a specific folder, run `scan-build make -o /some/folder`

Commit with changes on ODIN
---------------------------
make sure all test passes:
microbechmark, full regression an vtr strong regression test.

ODIN_II/verify_full.sh takes care of running all of them at once.
verify they are all successfull.
12 changes: 0 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,6 @@ On unix-like systems run `make` from the root VTR directory.

For more details see [here](BUILDING.md).

Development Debugging
========
First make sure you have clang installed.
define clang as the default compiler:
`export CC=clang`
`export CXX=clang++`

set to `debug` in makefile

On unix-like systems run `scan-build make` from the root VTR directory.
to output the html analysis to a specific folder, run `scan-build make -o /some/folder`

Docker Cloud9 Deployment
========================
We provide a Dockerfile that sets up all the necessary packages for VTR to run. Also, the Dockerfile sets up Cloud9, a workspace management system that runs on your browser and allows you to run (and modify) VTR remotely.
Expand Down
2 changes: 1 addition & 1 deletion libvtrutil/src/vtr_util.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ std::vector<std::string> ReadLineTokens(FILE * InFile, int *LineNum) {

int strcmp(const char* first, const char* second){
if(first && second){
return strncmp(first, second, vtr::BUFSIZE);
return strncmp(first, second, vtr::bufsize);
}else{
return -1;
}
Expand Down

0 comments on commit 01bd720

Please sign in to comment.