Properties with setters lack type annotations

[aatle]

Problem:
Almost all of the settable properties (such as Body.mass) are dynamically defined, so mypy doesn't recognize them. The properties get inferred to be of type Any (from the mixin), which is undesirable.

Suggestion:
Rewrite most of the writable properties in normal syntax, putting their docstring in the getter function. Static type checkers can then correctly see their type.
I can make the PR.

Exception:
Some properties are of Vec2d and so their setter accepts tuples, a different type than the getter. It has been pointed out before that type checkers don't recognize this.
So, these properties will be left alone.
Note: Mypy 1.16 adds support for getters and setters with different types. See the release notes.

[viblo]

Ah, I think there was some reason why I used the property function.. but now I dont remember. And regardless, seems like it all works as it should using the decorator nowadays so I think it would be a good improvement.

If you make a PR, great! The best is if you can do it against the pymunk7 branch ( https://github.com/viblo/pymunk/tree/pymunk7 ), since Im trying to finalize 7.0 there. Less risk of merge issues that way.

I saw they fixed it in mypy, nice! 🎉🎉 I even posted in the issue for it 5 years ago 😄 I wonder how quickly they will release. It would be nice if fixing Vec2d could happen at the same time (I mean with Pymunk 7.0), but who knows, might take a long time.. Anyway, if you do a PR for the rest I can also see when everything is set for 7.0 if this last bit can be done as well.

[viblo]

Looks like the vec2d improvements wont make it in time for Pymunk 7.0, Im planning to make a release soon, just some polish on release notes and final checks left I think.

[viblo]

Mypy 1.16 is now released! Just a day or two too late :) But maybe that was for the best.

[viblo]

Anyway, now it seems to handle for example Space.gravity correct if I rewrite as @property. However, I now see that Pyright / VSCode doesnt handle it the same way:

@property
    def gravity(self) -> Vec2d:
        ... 
@gravity.setter
    def gravity(self, gravity_vector: tuple[float, float]) -> None:
        ...

s = pymunk.Space()
s.gravity = 4, 5
s.gravity = Vec2d(s.gravity.y, s.gravity.x)

Will highlight red under .y and .x when creating the Vec2d. Instead it seems to require the type to be a Union of Vec2d and tuple in the setter: def gravity(self, gravity_vector: Union[Vec2d, tuple[float, float]]) -> None: My mistake, Union doesnt work as well

[viblo]

Yesterday when I tried again also VSCode/pyright worked.. maybe it was some caching going on previously, or they updated something.
Anyway, in Pymunk 7.1 just released this is fixed.