Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine current feature support at the player level #1147

Open
heff opened this issue Apr 14, 2014 · 0 comments
Open

Determine current feature support at the player level #1147

heff opened this issue Apr 14, 2014 · 0 comments
Labels
confirmed enhancement pinned Things that stalebot shouldn't close automatically

Comments

@heff
Copy link
Member

heff commented Apr 14, 2014

The volume and playbackRate controls currently hide themselves if the current tech (html5, flash, etc.) doesn't support the feature they need. In order to do this they currently have to access the tech directly to get this information, e.g. this.player_.tech.features ....

The goal of video.js is to abstract away the need to talk to the tech directly, so we need to find a better way to expose the current support for specific features.

It might look like this.player.features('volumeControl'). I'm not sure yet if that's the best way to phrase it or access that info.

You would use the loadstart event to check the current status of support and make updates as needed.

UPDATE

I'm currently like the player.supports() naming better, which was mentioned in #1474

@gkatsev gkatsev added the pinned Things that stalebot shouldn't close automatically label Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed enhancement pinned Things that stalebot shouldn't close automatically
Projects
None yet
Development

No branches or pull requests

2 participants