Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close button doesn't include vjs-icon-close class on the close button #3061

Open
gkatsev opened this issue Feb 1, 2016 · 0 comments
Open

close button doesn't include vjs-icon-close class on the close button #3061

gkatsev opened this issue Feb 1, 2016 · 0 comments
Labels
pinned Things that stalebot shouldn't close automatically

Comments

@gkatsev
Copy link
Member

gkatsev commented Feb 1, 2016 •
edited
Loading

We should make sure that the close button includes the correct class on itself.
We also probably should make sure that all elements include their respective icon classes as well to make it easier to override specific controls with specific icons.
@gkatsev gkatsev added the pinned Things that stalebot shouldn't close automatically label Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pinned Things that stalebot shouldn't close automatically
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gkatsev