Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live-video captions (CC) break when font is not 100% (emulated) #3887

Open
stsvilik opened this issue Dec 22, 2016 · 0 comments
Open

Live-video captions (CC) break when font is not 100% (emulated) #3887

stsvilik opened this issue Dec 22, 2016 · 0 comments
Labels
pinned Things that stalebot shouldn't close automatically

Comments

@stsvilik
Copy link

stsvilik commented Dec 22, 2016

Description

When using emulated closed captions on a live video and using "caption settings" to set font above or below 100%, captions collapse to the bottom of the screen and start appearing one on top of the other.

Example can be found here.

Steps to reproduce

  1. Wait until a live video is playing (ignore ad or intermission)
  2. Hover over "CC" and turn on caption
  3. Hover over "CC" again and click on "Gear" icon to show settings
  4. Change font size in the drop-down to anything other than 100%

Results

Expected

Captions to appear in the designated parts of the screen with just font size changing to what was set in the settings.

Actual

All captions appear on the bottom, overlaying one another as they come in.

Error output

No errors.

versions

videojs

5.12.6 (earlier versions have it too)

browsers

all

OSes

MacOS/Windows

plugins

are any videojs plugins being used on the page? If so, please list them below.
Hlsjs and several custom plugins.

@stsvilik stsvilik changed the title Live video emulated closed caption displays wrong when font is not 100% Live video closed captions display breaks when font is not 100% (emulated) Dec 23, 2016
@stsvilik stsvilik changed the title Live video closed captions display breaks when font is not 100% (emulated) Live video closed captions breaks when font is not 100% (emulated) Dec 23, 2016
@stsvilik stsvilik changed the title Live video closed captions breaks when font is not 100% (emulated) Live video closed captions break when font is not 100% (emulated) Jan 9, 2017
@stsvilik stsvilik changed the title Live video closed captions break when font is not 100% (emulated) Live-video captions (CC) break when font is not 100% (emulated) Jan 30, 2017
@gkatsev gkatsev added the pinned Things that stalebot shouldn't close automatically label Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Things that stalebot shouldn't close automatically
Projects
None yet
Development

No branches or pull requests

2 participants