Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 and pyflakes compatible code #2

Closed
adiroiban opened this issue Dec 8, 2013 · 2 comments
Closed

PEP8 and pyflakes compatible code #2

adiroiban opened this issue Dec 8, 2013 · 2 comments

Comments

@adiroiban
Copy link

Hi,

Is there any intent to make the arpy package pep8 or pyflakes compatible?

The main goal for making it pep8 compatible is to facilitate contribution from external developers. With pep8 developers don't have to learn a new style guide for each project they contribute.

pyflakes is a fast static analyzer and can help with keeping the code clean.

Maybe we can also make the source code ascii only, by escaping the unicode characters.

I am willing to contribute a patch if you are happy with this kind of changes

I can also write a small command to automatically check for pep8 or pyflakes warnings.

Thanks!

@viraptor
Copy link
Owner

Thanks for asking!
I'm not that happy about some pep8 rules to be honest. Anything that checks correctness, I'll be glad to accept as soon as possible (like F4xx, F8xx, E1xx and similar checks from flake8) - those could be added to the standard tox run too.

As for the rest, I'd rather see things easy flowing than force anyone to be pedantic about where to break a line with 81 characters ;)

@adiroiban
Copy link
Author

I agree that I am pedantic and that XP can still be controversial.

In our team we have pep and pyflakes integrated into our text editors, so each time we open a non-pep non-flakes compliant code the text editor goes crazy.

I find it hard to practice partial extreme programming. Not sure if you have read this article http://blog.8thlight.com/uncle-bob/2013/12/10/Thankyou-Kent.html

With pedantic checks for code guide we are trying to achieve collective wwnership - The notion that the code belongs to the team, not to the individual.

For me, applying pep8 or pyflakes is all or nothing, so I see little gain in applying selective PEP8 or pyflakes.
This is why I am not strongly motivated to continue working at fixing this ticket.

No hard feelings!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants