Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Mention defaultProps relation to getSubLayerProps in LayerExtension documentation #9120

Open
richard3d opened this issue Aug 29, 2024 · 0 comments
Labels

Comments

@richard3d
Copy link

Link

https://deck.gl/docs/developer-guide/custom-layers/layer-extensions#getsublayerprops

Description

I had written an extension and noticed none of the props were getting passed down to the sub layers in my composite layer I applied the extension to. After looking at the docs I noticed getSubLayerProps, however the thing that made it confusing was that when I looked at other extensions such as DataFilterExtenson this method was not defined. Yet, its properties were being added to the composite sublayers when I tested it. Really all a user needs to do is define default props and the base getSubLayerProps in the LayerExtension interface will work just fine without writing a bunch of copy code.

@richard3d richard3d added the doc label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant