Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tip: Use Permalink/RelPermalink instead of URL #123

Open
bep opened this issue Jan 25, 2018 · 0 comments
Open

Tip: Use Permalink/RelPermalink instead of URL #123

bep opened this issue Jan 25, 2018 · 0 comments
Assignees
@vjeantet
Labels
enhancement

Comments

@bep
Copy link

bep commented Jan 25, 2018

.

hugo-theme-docdock/layouts/partials/language-selector.html

Line 10 in bc3075a

<option id="{{ $translation.Language }}" value="{{ $translation.URL }}" selected>{{ .LanguageName }}</option>

I notice you use .URL on Page to build links. Which sounds obvious. A long story, but in general, you would be much better off using one of the two in the title. I'm going to deprecate and remove URL at some point, because it is misleading
@vjeantet vjeantet self-assigned this Jan 26, 2018
@divinerites divinerites mentioned this issue Apr 8, 2019
Open
Marthym added a commit to i-Run/hugo-theme-docdock that referenced this issue Aug 21, 2019
@Marthym
fix(layouts): Use .Permalink or .RelPermalink instead of .URL
5085a7c 
refs vjeantet#123
@Marthym Marthym mentioned this issue Aug 21, 2019
Merged
Marthym added a commit to i-Run/hugo-theme-docdock that referenced this issue Aug 22, 2019
@Marthym
fix(layouts): Fix URL for MenuEntry
fe7f42f 
URL was deprecated only for Page, not for MenuEntry

ref vjeantet#123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vjeantet vjeantet

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bep @vjeantet @Pilskalns