Skip to content
This repository has been archived by the owner on Nov 16, 2020. It is now read-only.

dispatch install should validate the image registry credentials #119

Open
3 of 9 tasks
neosab opened this issue Jan 12, 2018 · 1 comment
Open
3 of 9 tasks

dispatch install should validate the image registry credentials #119

neosab opened this issue Jan 12, 2018 · 1 comment
Labels

Comments

@neosab
Copy link
Contributor

neosab commented Jan 12, 2018

We should validate the user-specified image registry details in the install config. Otherwise, with an invalid registry, the installation is successful but creating functions could fail.

  • Bug
  • Feature
  • Enhancement

Detailed Description

Context

Possible Implementation

We can validate in the CLI but I would also prefer if this is done in the function manager as part of the driver initialization.

Complexity

  • Low - Simple enhancement or bug fix, no architectural changes or refactoring
  • Medium - Change requires some thought, but is relatively isolated
  • High - Significant architectural change or large refactor

Impact

  • Low - Annoyance, but does not impact business or functinality
  • Medium - Issue can be worked around, but is causing pain
  • High - Blocker

Your Environment

  • Dispatch CLI version (or git commit):
  • Dispatch Chart version (or image[s] tag):
  • Operating System and version:
  • Kubernetes version (and distribution):
  • Etc (any other useful environmental information):
@berndtj
Copy link
Contributor

berndtj commented Jan 29, 2018

Could we use the k8s readiness check for this? Though, I feel like it would be hard to relay the failure back to the user. We could introduce a "status" API and CLI which could relay the status of all the services with human readable error strings. This would probably also be good for general health monitoring.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants