Fix issue with test

Author: stephenafamo

strmangle.go

@@ -304,7 +304,7 @@ func titleCase(n string, trimLeftDigits bool) string {
 	// If the string is made up of only uppercase letters and underscores,
 	// then return as is and do not strip the underscores
 	// This keeps strings such as PUBLIC_KEY readable and not make it PUBLICKEY
-	if cleanN == strings.ToUpper(cleanN) {
+	if len(n) == len(cleanN) && n == strings.ToUpper(n) {
 		// Cache the title case as the same string
 		mut.Lock()
 		titleCaseCache[n] = cleanN

strmangle_test.go

@@ -204,6 +204,25 @@ func TestTrimLeftDigits(t *testing.T) {
 	}
 }
 
+func TestSanitizeForIdentifier(t *testing.T) {
+	t.Parallel()
+
+	tests := []struct {
+		In  string
+		Out string
+	}{
+		// No changes:
+		{"hello_there&", "hello_there_"},
+		{"FOO/BAR", "FOO_BAR"},
+	}
+
+	for i, test := range tests {
+		if out := sanitizeForIdentifier(test.In); out != test.Out {
+			t.Errorf("[%d] (%s) Out was wrong: %q, want: %q", i, test.In, out, test.Out)
+		}
+	}
+}
+
 func clearTitleCaseCache() {
 	mut.RLock()
 	titleCaseCache = map[string]string{}
@@ -233,6 +252,7 @@ func TestTitleCaseFull(t *testing.T) {
 		{"im_418_years_old", "Im418YearsOld"},
 		{"im_418years_old", "Im418yearsOld"},
 		{"418im_a_teapot", "ImATeapot"},
+		{"FOO/BAR", "FOO_BAR"},
 	}
 
 	for i, test := range tests {