Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules installed by r10k are not removed when removed from Puppetfile if Puppetfile contains no other modules #127

Open
jessereynolds opened this issue Aug 29, 2017 · 1 comment

Comments

@jessereynolds
Copy link
Collaborator

jessereynolds commented Aug 29, 2017

Steps to reproduce:

  • have stdlib as the only module in your Puppetfile and use one of its functions eg fact()
  • do a run spec and witness tests passing
  • remove stdlib from your Puppetfile, so there's no modules listed at all
  • do a run spec

Expected result:

  • test failure due to stdlib being missing

Actual result:

  • tests keep passing because stdlib module still resides at:
    .onceover/etc/puppetlabs/code/environments/production/modules/stdlib
    with a symlink to that dir at:
    .onceover/spec/fixtures/modules/stdlib

In fact, the debug run still shows it is faithfully maintaining that symlink too:

DEBUG -> Symlinking /Users/jesse/src/puppet/gems/onceover/tmp/control-repos/simple/.onceover/etc/puppetlabs/code/environments/production/modules/stdlib to /Users/jesse/src/puppet/gems/onceover/tmp/control-repos/simple/.onceover/spec/fixtures/modules/stdlib

@jessereynolds jessereynolds changed the title modules installed by r10k are not removed when removed from Puppetfile modules installed by r10k are not removed when removed from Puppetfile if Puppetfile contains no other modules Aug 29, 2017
@jessereynolds
Copy link
Collaborator Author

This is caused by puppetlabs/r10k#762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants