Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize number and date formats #1874

Open
davicostalf opened this issue Aug 23, 2024 · 1 comment
Open

Standardize number and date formats #1874

davicostalf opened this issue Aug 23, 2024 · 1 comment
Assignees
Labels
design Indicates that the issue or pull request involves design considerations idea Suggestions or requests for enhancements to the software

Comments

@davicostalf
Copy link
Contributor

davicostalf commented Aug 23, 2024

Problem

We use numeric information in multiple components, but we have no guideline in Shoreline on how they should be formatted. Ideally, it should be very clear to designers what formats they should follow and it should be very easy for developers to implement these formats.

Solution

There are already some clues on what directions we should follow:

Some things that I would like to note:

  • Using a format for currency such as "0,000.00 USD" is more precise than "$0,000.00" since multiple currencies use the dollar sign.
  • Using a format for date such as "Mon DD, YYYY" seems more precise than "00/00/0000" since depending on the person's culture it can be interpreted either as "DD/MM/YYYY" or "MM/DD/YYYY".

Usage examples

Date pickers, table column cells, information in cards, filters, etc.

Dependencies

We need to align with the localization and education team on a direction.

References

There is documentation from other design systems that we can use as basis. For example:

@davicostalf davicostalf added design Indicates that the issue or pull request involves design considerations idea Suggestions or requests for enhancements to the software labels Aug 23, 2024
@davicostalf
Copy link
Contributor Author

This is being tackled by the localization team

@davicostalf davicostalf self-assigned this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Indicates that the issue or pull request involves design considerations idea Suggestions or requests for enhancements to the software
Projects
Status: Active
Development

No branches or pull requests

1 participant