From 4b593f85fd5565195209d6bbe753219715cc1c82 Mon Sep 17 00:00:00 2001 From: Felix Rieseberg Date: Mon, 3 Sep 2018 20:10:26 -0700 Subject: [PATCH 1/3] docs: Add windows-build-tools for Windows users --- README.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index a7996f91..2676fc6a 100644 --- a/README.md +++ b/README.md @@ -82,12 +82,18 @@ var W3CWebSocket = require('websocket').w3cwebsocket; Note for Windows Users ---------------------- -Because there is a small C++ component used for validating UTF-8 data, you will need to install a few other software packages in addition to Node to be able to build this module: +Because there is a small C++ component used for validating UTF-8 data, you will need to install +native build tools. You can install the required components using `windows-build-tools`: + +```ps1 +npm install --global --production windows-build-tools +``` + +Alternatively, install the required components: - [Microsoft Visual C++](http://www.microsoft.com/visualstudio/en-us/products/2010-editions/visual-cpp-express) - [Python 2.7](http://www.python.org/download/) (NOT Python 3.x) - Current Features: ----------------- - Licensed under the Apache License, Version 2.0 From e109ba6b2c4d2bcf4b0f4c0aa7a60855a3cf0c12 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?I=C3=B1aki=20Baz=20Castillo?= Date: Wed, 24 Apr 2019 16:38:40 +0200 Subject: [PATCH 2/3] Include .git/ into .npmignore (fix #353) - When .npmignore file is present, the content of the .gitignore file is ignored. - So also include more files and folders in .npmignore file. --- .gitignore | 5 ++--- .npmignore | 7 ++++++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index 10cbcbeb..ba3ad330 100644 --- a/.gitignore +++ b/.gitignore @@ -1,8 +1,7 @@ -node_modules +node_modules/ .DS_Store .lock-* -build -build/* +build/ builderror.log npm-debug.log test/autobahn/reports*/* diff --git a/.npmignore b/.npmignore index d040b5c0..4718deae 100644 --- a/.npmignore +++ b/.npmignore @@ -1,7 +1,12 @@ .npmignore .gitignore +.git/ +.DS_Store +.lock-* +node_modules/ docs/ example/ build/ +builderror.log +npm-debug.log test/ -node_modules/ From 3cb29e1041ecca0a9c21f809890204271900f6f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?I=C3=B1aki=20Baz=20Castillo?= Date: Fri, 7 Jun 2019 19:28:31 +0200 Subject: [PATCH 3/3] Fix gulp dependency version (git URL no longer required as 4.0.2 is already published) --- .npmrc | 1 + package.json | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 .npmrc diff --git a/.npmrc b/.npmrc new file mode 100644 index 00000000..43c97e71 --- /dev/null +++ b/.npmrc @@ -0,0 +1 @@ +package-lock=false diff --git a/package.json b/package.json index 9c8730f5..96bd0136 100644 --- a/package.json +++ b/package.json @@ -28,6 +28,7 @@ }, "dependencies": { "debug": "^2.2.0", + "gulp": "^4.0.2", "nan": "^2.3.3", "typedarray-to-buffer": "^3.1.5", "yaeti": "^0.0.6" @@ -35,7 +36,6 @@ "devDependencies": { "buffer-equal": "^1.0.0", "faucet": "^0.0.1", - "gulp": "git+https://github.com/gulpjs/gulp.git#4.0", "gulp-jshint": "^2.0.4", "jshint-stylish": "^2.2.1", "jshint": "^2.0.0",