Skip to content

Commit 1db5dce

Browse files
authored
Merge pull request RustPython#2107 from clemado1/develop
Fix error message in objsequence.get_item
2 parents 1011f48 + 6523abc commit 1db5dce

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

Lib/test/list_tests.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ def test_init(self):
3333
self.assertNotEqual(id(a), id(b))
3434
self.assertEqual(a, b)
3535

36-
# TODO: RUSTPYTHON
37-
@unittest.expectedFailure
3836
def test_getitem_error(self):
3937
a = []
4038
msg = "list indices must be integers or slices"

Lib/test/test_tuple.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
class TupleTest(seq_tests.CommonTest):
1919
type2test = tuple
2020

21-
# TODO: RUSTPYTHON
22-
@unittest.expectedFailure
2321
def test_getitem_error(self):
2422
t = ()
2523
msg = "tuple indices must be integers or slices"

vm/src/obj/objsequence.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,8 +252,8 @@ pub fn get_item(
252252
}
253253
} else {
254254
Err(vm.new_type_error(format!(
255-
"indexing type {:?} with index {:?} is not supported (yet?)",
256-
sequence, subscript
255+
"{} indices must be integers or slices",
256+
sequence.lease_class().name
257257
)))
258258
}
259259
}

0 commit comments

Comments
 (0)