Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filters should be applied in linear rgb space #71

Open
weisJ opened this issue Mar 7, 2024 · 1 comment
Open

Filters should be applied in linear rgb space #71

weisJ opened this issue Mar 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@weisJ
Copy link
Owner

weisJ commented Mar 7, 2024

For the most part this doesn't make that much of a difference. However for feColorMatrix the difference is very much noticeable. Fixing this might also make gaussian blurs more closely match the spec/batik.

Currently colourspaces aren't checked. In particular feColorMatrix always filters in sRGB.
@weisJ weisJ added the enhancement New feature or request label Mar 7, 2024
@weisJ
Copy link
Owner Author

weisJ commented Mar 11, 2024

feColorMatrix and feBlend now do this correctly. Other filters will need to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weisJ