Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question re: HttpClient #95

Open
RaiseJohnBarry opened this issue Sep 1, 2017 · 2 comments
Open

Question re: HttpClient #95

RaiseJohnBarry opened this issue Sep 1, 2017 · 2 comments

Comments

@RaiseJohnBarry
Copy link
Contributor

The httpclient that gets compiled here is pretty old - httpclient-4.0.1.jar
The current is httpclient-4.5.3.jar -- this normally wouldn't be a big issue but kafkaconnect doesn't isolate classpaths until 3.3 so confluent 3.2.1/3.2.2 has trouble running the S3 connector and bigquery simultaneously.

Was considering a PR to bring the gradle build's http client up but was wondering your thoughts on this.
@criccomini
Copy link
Contributor

PR is welcome! As long as things continue to function as before, I'm all for upgrading the library.

@apoorvmittal10
Copy link
Contributor

@criccomini Seems this has been fixed under #148. @RaiseJohnBarry Can you please confirm, so the issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@criccomini @apoorvmittal10 @RaiseJohnBarry