Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI for DiT #3

Open
zen-d opened this issue Feb 26, 2024 · 0 comments
Open

PI for DiT #3

zen-d opened this issue Feb 26, 2024 · 0 comments

Comments

@zen-d
Copy link

zen-d commented Feb 26, 2024

Hi @whlzy, thanks for your work. As far as I am concerned, DiT also uses absolute position encoding.
How do you apply PI to DiT? Even though it is implemented on absolute PE, will the effect be just like EI (embedding interpolation)?

In contrast, the original PI publication is based on Rotary position encoding. Please correct it if I miss anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant