Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📘 DOC: Add usage of --site to /guides/deploy for preview sites #113

Closed
jasikpark opened this issue Jul 24, 2021 · 8 comments
Closed

📘 DOC: Add usage of --site to /guides/deploy for preview sites #113

jasikpark opened this issue Jul 24, 2021 · 8 comments

Comments

@jasikpark
Copy link
Contributor

For example on Netlify we should add

yarn build --site $DEPLOY_PRIME_URL

for Deploy Previews and Branch Deploys in the explanation

@aFuzzyBear
Copy link
Contributor

done, ill post this with my work at the end of the day

@aFuzzyBear
Copy link
Contributor

Do I need to explain what $DEPLOY_PRIME_URL is, is this env used solely by netlify? or just by having as is, is enough without any prior ref to the variable in the setup preamble?

@jasikpark
Copy link
Contributor Author

Do I need to explain what $DEPLOY_PRIME_URL is, is this env used solely by netlify? or just by having as is, is enough without any prior ref to the variable in the setup preamble?

I would link to the Netlify Docs and also generally describe it in the docs.

@aFuzzyBear
Copy link
Contributor

lol i have "link deployments with references" on my to-do list

I think ill defer on the write up for the description, if you dont mind putting one together, then see how we could incorporate them into the docs

@FredKSchott
Copy link
Member

Nice! If you want to create a PR without the description, then we could add that later

@aFuzzyBear
Copy link
Contributor

will do, sorry was busy yesterday, and got distracted with something,

@FredKSchott FredKSchott transferred this issue from withastro/astro Jan 29, 2022
@sarah11918
Copy link
Member

Ya got reeeeeaaallly distracted, @aFuzzyBear ! 😅

Should this still be an open issue?

@aFuzzyBear
Copy link
Contributor

😂😂 no anymore, we got the one click deploys on the repository now along with all the ide integrations, I think this is safe to close,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants