forked from XiaoMi/soar
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathheuristic_test.go
3025 lines (2877 loc) · 81.7 KB
/
heuristic_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*
* Copyright 2018 Xiaomi, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package advisor
import (
"errors"
"sort"
"testing"
"github.com/XiaoMi/soar/common"
"github.com/kr/pretty"
)
// ALI.001
func TestRuleImplicitAlias(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := [][]string{
{
"select col c from tbl where id < 1000",
"select col from tbl tb where id < 1000",
},
{
"do 1",
},
}
for _, sql := range sqls[0] {
q, _ := NewQuery4Audit(sql)
rule := q.RuleImplicitAlias()
if rule.Item != "ALI.001" {
t.Error("Rule not match:", rule.Item, "Expect : ALI.001")
}
}
for _, sql := range sqls[1] {
q, _ := NewQuery4Audit(sql)
rule := q.RuleImplicitAlias()
if rule.Item != "OK" {
t.Error("Rule not match:", rule.Item, "Expect : OK")
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// ALI.002
func TestRuleStarAlias(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"select tbl.* as c1,c2,c3 from tbl where id < 1000",
}
for _, sql := range sqls {
q, _ := NewQuery4Audit(sql)
rule := q.RuleStarAlias()
if rule.Item != "ALI.002" {
t.Error("Rule not match:", rule.Item, "Expect : ALI.002")
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// ALI.003
func TestRuleSameAlias(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"select col as col from tbl where id < 1000",
"select col from tbl as tbl where id < 1000",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleSameAlias()
if rule.Item != "ALI.003" {
t.Error("Rule not match:", rule.Item, "Expect : ALI.003")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// ARG.001
func TestRulePrefixLike(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"select col from tbl where id like '%abc'",
"select col from tbl where id like '_abc'",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RulePrefixLike()
if rule.Item != "ARG.001" {
t.Error("Rule not match:", rule.Item, "Expect : ARG.001")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// ARG.002
func TestRuleEqualLike(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"select col from tbl where id like 'abc'",
"select col from tbl where id like 1",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleEqualLike()
if rule.Item != "ARG.002" {
t.Error("Rule not match:", rule.Item, "Expect : ARG.002")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// CLA.001
func TestRuleNoWhere(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := [][]string{
{"select col from tbl",
"delete from tbl",
"update tbl set col=1",
"insert into city (country_id) select country_id from country",
},
{
`select 1;`,
},
}
for _, sql := range sqls[0] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleNoWhere()
if rule.Item != "CLA.001" && rule.Item != "CLA.014" && rule.Item != "CLA.015" {
t.Error("Rule not match:", rule.Item, "Expect : CLA.001/CLA.014/CLA.015")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
for _, sql := range sqls[1] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleNoWhere()
if rule.Item != "OK" {
t.Error("Rule not match:", rule.Item, "Expect : OK")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// CLA.002
func TestRuleOrderByRand(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"select col from tbl where id = 1 order by rand()",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleOrderByRand()
if rule.Item != "CLA.002" {
t.Error("Rule not match:", rule.Item, "Expect : CLA.002")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// CLA.003
func TestRuleOffsetLimit(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"select c1,c2 from tbl where name=xx order by number limit 1 offset 2000",
"select c1,c2 from tbl where name=xx order by number limit 2000,1",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleOffsetLimit()
if rule.Item != "CLA.003" {
t.Error("Rule not match:", rule.Item, "Expect : CLA.003")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// CLA.004
func TestRuleGroupByConst(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"select col1,col2 from tbl where col1='abc' group by 1",
"select col1,col2 from tbl group by 1",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleGroupByConst()
if rule.Item != "CLA.004" {
t.Error("Rule not match:", rule.Item, "Expect : CLA.004")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// CLA.005
func TestRuleOrderByConst(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
// "select id from test where id=1 order by id",
"select id from test where id=1 order by 1",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleOrderByConst()
if rule.Item != "CLA.005" {
t.Error("Rule not match:", rule.Item, "Expect : CLA.005")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// CLA.006
func TestRuleDiffGroupByOrderBy(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"select tb1.col, tb2.col from tb1, tb2 where id=1 group by tb1.col, tb2.col",
"select tb1.col, tb2.col from tb1, tb2 where id=1 order by tb1.col, tb2.col",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleDiffGroupByOrderBy()
if rule.Item != "CLA.006" {
t.Error("Rule not match:", rule.Item, "Expect : CLA.006")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// CLA.007
func TestRuleMixOrderBy(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"select c1,c2,c3 from t1 where c1='foo' order by c2 desc, c3 asc",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleMixOrderBy()
if rule.Item != "CLA.007" {
t.Error("Rule not match:", rule.Item, "Expect : CLA.007")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// CLA.008
func TestRuleExplicitOrderBy(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"select c1,c2,c3 from t1 where c1='foo' group by c2",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleExplicitOrderBy()
if rule.Item != "CLA.008" {
t.Error("Rule not match:", rule.Item, "Expect : CLA.008")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// CLA.009
func TestRuleOrderByExpr(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"SELECT col FROM tbl order by cola - colb;", // order by 列运算
"SELECT cola - colb col FROM tbl order by col;", // 别名为列运算
"SELECT cola FROM tbl order by from_unixtime(col);", // order by 函数运算
"SELECT from_unixtime(col) cola FROM tbl order by cola;", // 别名为函数运算
// 反面例子
// `SELECT tbl.col FROM tbl ORDER BY col`,
// "SELECT sum(col) AS col FROM tbl ORDER BY dt",
// "SELECT tbl.col FROM tb, tbl WHERE tbl.tag_id = tb.id ORDER BY tbl.col",
// "SELECT col FROM tbl order by `timestamp`;", // 列名为关键字
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleOrderByExpr()
if rule.Item != "CLA.009" {
t.Error("Rule not match:", rule.Item, "Expect : CLA.009")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// CLA.010
func TestRuleGroupByExpr(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"SELECT col FROM tbl GROUP by cola - colb;",
"SELECT cola - colb col FROM tbl GROUP by col;",
"SELECT cola FROM tbl GROUP by from_unixtime(col);",
"SELECT from_unixtime(col) cola FROM tbl GROUP by cola;",
// 反面例子
// `SELECT tbl.col FROM tbl GROUP BY col`,
// "SELECT dt, sum(col) AS col FROM tbl GROUP BY dt",
// "SELECT tbl.col FROM tb, tbl WHERE tbl.tag_id = tb.id GROUP BY tbl.col",
// "SELECT col FROM tbl GROUP by `timestamp`;", // 列名为关键字
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleGroupByExpr()
if rule.Item != "CLA.010" {
t.Error("Rule not match:", rule.Item, "Expect : CLA.010")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// CLA.011
func TestRuleTblCommentCheck(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"CREATE TABLE `test1`( `ID` bigint(20) NOT NULL AUTO_INCREMENT," +
" `c1` varchar(128) DEFAULT NULL, `c2` varchar(300) DEFAULT NULL," +
" `c3` varchar(32) DEFAULT NULL, `c4` int(11) NOT NULL, `c5` double NOT NULL," +
" `c6` text NOT NULL, PRIMARY KEY (`ID`), KEY `idx_c3_c2_c4_c5_c6` " +
"(`c3`,`c2`(255),`c4`,`c5`,`c6`(255)), KEY `idx_c3_c2_c4` (`c3`,`c2`,`c4`)) " +
"ENGINE=InnoDB DEFAULT CHARSET=utf8",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleTblCommentCheck()
if rule.Item != "CLA.011" {
t.Error("Rule not match:", rule.Item, "Expect : CLA.011")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// COL.001
func TestRuleSelectStar(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"select * from tbl where id=1",
"select col, * from tbl where id=1",
// 反面例子
// "select count(*) from film where id=1",
// `select count(* ) from film where id=1`,
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleSelectStar()
if rule.Item != "COL.001" {
t.Error("Rule not match:", rule.Item, "Expect : COL.001")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// COL.002
func TestRuleInsertColDef(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"insert into tbl values(1,'name')",
"replace into tbl values(1,'name')",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleInsertColDef()
if rule.Item != "COL.002" {
t.Error("Rule not match:", rule.Item, "Expect : COL.002")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// COL.004
func TestRuleAddDefaultValue(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := [][]string{
{
"create table test(id int)",
`ALTER TABLE test change id id varchar(10);`,
`ALTER TABLE test modify id varchar(10);`,
},
{
`ALTER TABLE test modify id varchar(10) DEFAULT '';`,
`ALTER TABLE test CHANGE id id varchar(10) DEFAULT '';`,
"create table test(id int not null default 0 comment '用户id')",
},
}
for _, sql := range sqls[0] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleAddDefaultValue()
if rule.Item != "COL.004" {
t.Error("Rule not match:", rule.Item, "Expect : COL.004")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
for _, sql := range sqls[1] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleAddDefaultValue()
if rule.Item != "OK" {
t.Error("Rule not match:", rule.Item, "Expect : OK")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// COL.005
func TestRuleColCommentCheck(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := [][]string{
{
"create table test(id int not null default 0)",
`alter table test add column a int`,
`ALTER TABLE t1 CHANGE b b INT NOT NULL;`,
},
{
"create table test(id int not null default 0 comment '用户id')",
`alter table test add column a int comment 'test'`,
`ALTER TABLE t1 AUTO_INCREMENT = 13;`,
`ALTER TABLE t1 CHANGE b b INT NOT NULL COMMENT 'test';`,
},
}
for _, sql := range sqls[0] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleColCommentCheck()
if rule.Item != "COL.005" {
t.Error("Rule not match:", rule.Item, "Expect : COL.005")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
for _, sql := range sqls[1] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleColCommentCheck()
if rule.Item != "OK" {
t.Error("Rule not match:", rule.Item, "Expect : OK")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// LIT.001
func TestRuleIPString(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"insert into tbl (IP,name) values('10.20.306.122','test')",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleIPString()
if rule.Item != "LIT.001" {
t.Error("Rule not match:", rule.Item, "Expect : LIT.001")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// LIT.002
func TestRuleDataNotQuote(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"select col1,col2 from tbl where time < 2018-01-10",
"select col1,col2 from tbl where time < 18-01-10",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleDataNotQuote()
if rule.Item != "LIT.002" {
t.Error("Rule not match:", rule.Item, "Expect : LIT.002")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// KWR.001
func TestRuleSQLCalcFoundRows(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"select SQL_CALC_FOUND_ROWS col from tbl where id>1000",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleSQLCalcFoundRows()
if rule.Item != "KWR.001" {
t.Error("Rule not match:", rule.Item, "Expect : KWR.001")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// JOI.001
func TestRuleCommaAnsiJoin(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
`select c1,c2,c3 from t1,t2 join t3 on t1.c1=t2.c1 and t1.c3=t3.c1 where id>1000;`,
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleCommaAnsiJoin()
if rule.Item != "JOI.001" {
t.Error("Rule not match:", rule.Item, "Expect : JOI.001")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// JOI.002
func TestRuleDupJoin(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
`select tb1.col from (tb1, tb2) join tb2 on tb1.id=tb.id where tb1.id=1;`,
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleDupJoin()
if rule.Item != "JOI.002" {
t.Error("Rule not match:", rule.Item, "Expect : JOI.002")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// RES.001
func TestRuleNoDeterministicGroupby(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := [][]string{
// 正面CASE
{
"select c1,c2,c3 from t1 where c2='foo' group by c2",
"select col, col2, sum(col1) from tb group by col",
"select col, col1 from tb group by col,sum(col1)",
"select * from tb group by col",
},
// 反面CASE
{
"select id from film",
"select col, sum(col1) from tb group by col",
"select * from file",
"SELECT COUNT(*) AS cnt, language_id FROM film GROUP BY language_id;",
"SELECT COUNT(*) AS cnt FROM film GROUP BY language_id;",
},
}
for _, sql := range sqls[0] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleNoDeterministicGroupby()
if rule.Item != "RES.001" {
t.Error("Rule not match:", rule.Item, "Expect : RES.001")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
for _, sql := range sqls[1] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleNoDeterministicGroupby()
if rule.Item != "OK" {
t.Error("Rule not match:", rule.Item, "Expect : OK")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// RES.002
func TestRuleNoDeterministicLimit(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"select col1,col2 from tbl where name='tony' limit 10",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleNoDeterministicLimit()
if rule.Item != "RES.002" {
t.Error("Rule not match:", rule.Item, "Expect : RES.002")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// RES.003
func TestRuleUpdateDeleteWithLimit(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := [][]string{
{
"UPDATE film SET length = 120 WHERE title = 'abc' LIMIT 1;",
},
{
"UPDATE film SET length = 120 WHERE title = 'abc';",
},
}
for _, sql := range sqls[0] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleUpdateDeleteWithLimit()
if rule.Item != "RES.003" {
t.Error("Rule not match:", rule.Item, "Expect : RES.003")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
for _, sql := range sqls[1] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleUpdateDeleteWithLimit()
if rule.Item != "OK" {
t.Error("Rule not match:", rule.Item, "Expect : OK")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// RES.004
func TestRuleUpdateDeleteWithOrderby(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := [][]string{
{
"UPDATE film SET length = 120 WHERE title = 'abc' ORDER BY title;",
},
{
"UPDATE film SET length = 120 WHERE title = 'abc';",
},
}
for _, sql := range sqls[0] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleUpdateDeleteWithOrderby()
if rule.Item != "RES.004" {
t.Error("Rule not match:", rule.Item, "Expect : RES.004")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
for _, sql := range sqls[1] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleUpdateDeleteWithOrderby()
if rule.Item != "OK" {
t.Error("Rule not match:", rule.Item, "Expect : OK")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// RES.005
func TestRuleUpdateSetAnd(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := [][]string{
{
"update tbl set col = 1 and cl = 2 where col=3;",
},
{
"update tbl set col = 1 ,cl = 2 where col=3;",
},
}
for _, sql := range sqls[0] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleUpdateSetAnd()
if rule.Item != "RES.005" {
t.Error("Rule not match:", rule.Item, "Expect : RES.005")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
for _, sql := range sqls[1] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleUpdateSetAnd()
if rule.Item != "OK" {
t.Error("Rule not match:", rule.Item, "Expect : OK")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// RES.006
func TestRuleImpossibleWhere(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := [][]string{
{
"select * from tbl where 1 != 1;",
"select * from tbl where 'a' != 'a';",
"select * from tbl where col between 10 AND 5;",
},
{
"select * from tbl where 1 = 1;",
"select * from tbl where 'a' != 1;",
},
}
for _, sql := range sqls[0] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleImpossibleWhere()
if rule.Item != "RES.006" {
t.Error("Rule not match:", rule.Item, "Expect : RES.006, SQL: ", sql)
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
for _, sql := range sqls[1] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleImpossibleWhere()
if rule.Item != "OK" {
t.Error("Rule not match:", rule.Item, "Expect : OK, SQL: ", sql)
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// RES.007
func TestRuleMeaninglessWhere(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := [][]string{
{
"select * from tbl where 1 = 1;",
"select * from tbl where 'a' = 'a';",
"select * from tbl where 'a' != 1;",
"select * from tbl where 'a';",
"select * from tbl where 'a' limit 1;",
"select * from tbl where 1;",
"select * from tbl where 1 limit 1;",
},
{
"select * from tbl where 2 = 1;",
"select * from tbl where 'b' = 'a';",
},
}
for _, sql := range sqls[0] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleMeaninglessWhere()
if rule.Item != "RES.007" {
t.Error("Rule not match:", rule.Item, "Expect : RES.007, SQL: ", sql)
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
for _, sql := range sqls[1] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleMeaninglessWhere()
if rule.Item != "OK" {
t.Error("Rule not match:", rule.Item, "Expect : OK, SQL: ", sql)
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// RES.008
func TestRuleLoadFile(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := [][]string{
{
"LOAD DATA INFILE 'data.txt' INTO TABLE db2.my_table;",
"LOAD DATA INFILE 'data.txt' INTO TABLE db2.my_table;",
"LOAD /*COMMENT*/DATA INFILE 'data.txt' INTO TABLE db2.my_table;",
`SELECT a,b,a+b INTO OUTFILE '/tmp/result.txt' FIELDS TERMINATED BY ',' OPTIONALLY ENCLOSED BY '"' LINES TERMINATED BY '\n' FROM test_table;`,
},
{
"SELECT id, data INTO @x, @y FROM test.t1 LIMIT 1;",
},
}
for _, sql := range sqls[0] {
q := &Query4Audit{Query: sql}
rule := q.RuleLoadFile()
if rule.Item != "RES.008" {
t.Error("Rule not match:", rule.Item, "Expect : RES.008, SQL: ", sql)
}
}
for _, sql := range sqls[1] {
q := &Query4Audit{Query: sql}
rule := q.RuleLoadFile()
if rule.Item != "OK" {
t.Error("Rule not match:", rule.Item, "Expect : OK, SQL: ", sql)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// STA.001
func TestRuleStandardINEQ(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := []string{
"select col1,col2 from tbl where type!=0",
// "select col1,col2 from tbl where type<>0",
}
for _, sql := range sqls {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleStandardINEQ()
if rule.Item != "STA.001" {
t.Error("Rule not match:", rule.Item, "Expect : STA.001")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// KWR.002
func TestRuleUseKeyWord(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := [][]string{
{
"CREATE TABLE tbl (`select` int)",
"CREATE TABLE `select` (a int)",
"ALTER TABLE tbl ADD COLUMN `select` varchar(10)",
},
{
"CREATE TABLE tbl (a int)",
"ALTER TABLE tbl ADD COLUMN col varchar(10)",
},
}
for _, sql := range sqls[0] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleUseKeyWord()
if rule.Item != "KWR.002" {
t.Error("Rule not match:", rule.Item, "Expect : KWR.002")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
for _, sql := range sqls[1] {
q, err := NewQuery4Audit(sql)
if err == nil {
rule := q.RuleUseKeyWord()
if rule.Item != "OK" {
t.Error("Rule not match:", rule.Item, "Expect : OK")
}
} else {
t.Error("sqlparser.Parse Error:", err)
}
}
common.Log.Debug("Exiting function: %s", common.GetFunctionName())
}
// KWR.003
func TestRulePluralWord(t *testing.T) {
common.Log.Debug("Entering function: %s", common.GetFunctionName())
sqls := [][]string{
{
"CREATE TABLE tbl (`people` int)",
"CREATE TABLE people (a int)",
"ALTER TABLE tbl ADD COLUMN people varchar(10)",
},
{
"CREATE TABLE tbl (`person` int)",
"ALTER TABLE tbl ADD COLUMN person varchar(10)",
},
}
for _, sql := range sqls[0] {
q, err := NewQuery4Audit(sql)