Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning suppression in prod mode: "Warning: Failed prop type: The prop amPm is marked as required in Hour12Input, but its value is null." #31

Closed
emilyuhde opened this issue Jun 20, 2019 · 3 comments
Closed

Warning suppression in prod mode: "Warning: Failed prop type: The prop amPm is marked as required in Hour12Input, but its value is null." #31

emilyuhde opened this issue Jun 20, 2019 · 3 comments
Assignees
@wojtekmaj
Labels
bug Something isn't working

Comments

@emilyuhde
Copy link
Contributor

Is it possible to have this warning suppressed in prod mode or offer some way to turn it off?

If the value of the time picker is initialized to null for a 12 hour formatted time, this warning will show up in the console. The warning makes sense, but I don't want the warning all the time, especially for a non-required time picker.

Screen Shot 2019-06-20 at 9 06 05 AM
@wojtekmaj
Copy link
Owner

Please see discussion in #24

@emilyuhde emilyuhde mentioned this issue Jun 22, 2019
Closed
@wojtekmaj wojtekmaj self-assigned this Jun 27, 2019
@wojtekmaj wojtekmaj added the bug Something isn't working label Jun 27, 2019
@wojtekmaj
Copy link
Owner

Analyzed that and it turns out this wasn't really required prop. Yay!

@wojtekmaj
Copy link
Owner

Just a heads-up - React-Time-Picker v3.6.0 was released a few moments ago and includes the fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wojtekmaj wojtekmaj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emilyuhde @wojtekmaj