-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make references to image/ and jsonrpc relative #140
Comments
Similar issues have been raised against Chorus 1 The above includes this slightly more in depth description:
The issue for images is essentially the same. I've worked around that slightly in #133 by re-pointing those locations to the kodi webserver as well but its really not good practice becuase it prevents the owner using /images or /jasonrpc for their own things. |
I'm thinking the best solution for this is to add the ability to override the /jsonrpc and /images paths in the settings page. Would that solve this issue? |
It would but it seems like an unnecessarily complicated solution for both you as the implementer and for the end users. This should in theory be just a string operation to strip the leading slash from certain uris. in theory this should not break anything else. The above requires capturing an additional variable in setting and then prepending that to all the above mentioned URIs,, they will probably have to experiment to work out whether they need to add the leading or training slash to those settings items. |
links to image and jsonrpc start with a leading slash, this makes proxying more complicated.
I think all that is required here is to remove the leading slash when proxying
The text was updated successfully, but these errors were encountered: