Skip to content

Commit e219b58

Browse files
committed
Fixed first CR comments
1 parent 9f8bcad commit e219b58

File tree

6 files changed

+42
-41
lines changed

6 files changed

+42
-41
lines changed

demo/v2-demo/images/new.svg

+6-17
Loading

demo/v2-demo/scripts/report.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -135,14 +135,15 @@ function OpenInteractStep() {
135135
}
136136
else
137137
{
138-
$("#settings").load("settings_interact.html", function() {
138+
$("#settings").load("settings_interact.html", function() {
139139
SetToggleHandler("report-operations-div");
140140
SetToggleHandler("page-operations-div");
141141
SetToggleHandler("events-operations-div");
142142
SetToggleHandler("editandsave-operations-div");
143143
LoadCodeArea("#embedCodeDiv", _Report_GetId);
144+
AddImgToNewOperations();
144145
});
145-
}
146+
}
146147
}
147148

148149
function setCodeArea(mode, entityType)

demo/v2-demo/scripts/utils.js

+17
Original file line numberDiff line numberDiff line change
@@ -80,3 +80,20 @@ function CopyTextArea(textAreaSelector, buttonSelector) {
8080
function ClearTextArea(textAreaSelector) {
8181
$(textAreaSelector).val("");
8282
}
83+
84+
function AddImgToNewOperations(){
85+
var newListItems = $('.newOperation');
86+
newListItems.each(function(index, value)
87+
{
88+
var pElement = document.createElement("p");
89+
pElement.innerText = value.innerText;
90+
91+
var newImgElement = document.createElement("img");
92+
newImgElement.src = "images\\new.svg";
93+
94+
value.innerText = '';
95+
value.appendChild(pElement);
96+
value.appendChild(newImgElement);
97+
98+
});
99+
}

demo/v2-demo/settings_interact.html

+2-8
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,8 @@
3232
<li class="" onclick="Report_UpdateSettings()">Update settings</li>
3333
<li class="" onclick="Report_Reload()">Reload</li>
3434
<li class="" onclick="Report_Refresh()">Refresh</li>
35-
<li class="newOperation" onclick="Report_Extensions_OptionsMenu()">
36-
<p>Extend options menu</p>
37-
<img src="images\new.svg"/>
38-
</li>
39-
<li class="newOperation" onclick="Report_Extensions_ContextMenu()">
40-
<p>Extend context menu</p>
41-
<img src="images\new.svg"/>
42-
</li>
35+
<li class="newOperation" onclick="Report_Extensions_OptionsMenu()">Extend options menu</li>
36+
<li class="newOperation" onclick="Report_Extensions_ContextMenu()">Extend context menu</li>
4337
<li class="" onclick="Report_FullScreen()">Full screen</li>
4438
<li class="" onclick="Report_ExitFullScreen()">Exit full screen</li>
4539
</ul>

demo/v2-demo/step_authorize.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ <h3>Sample Report</h3>
1212

1313
<div id="sampleQna" class="pbi-line">
1414
<div class="pageTitle">
15-
<div class="pageTitleNewItem">
15+
<div class="newItem">
1616
<h3>Sample Q&A</h3>
17-
<img src="images\new.svg" class = "textAreaControl"/>
17+
<img src="images\new.svg"/>
1818
</div>
1919
<h8>You can embed a sample Q&A and interact with Power BI Embedded firsthand by clicking below.</h8>
2020
</div>

demo/v2-demo/style/style.css

+12-12
Original file line numberDiff line numberDiff line change
@@ -423,17 +423,18 @@ a {
423423
padding: 0px 20px 0px 0px;
424424
}
425425

426-
.newOperation{
427-
display: flex;
426+
.newOperation {
427+
display: flex;
428428
}
429429

430-
.newOperation p{
431-
display: inline-block;
432-
padding-right: 10px;
433-
margin-bottom: 0px;
430+
.newOperation p {
431+
display: inline-block;
432+
padding-right: 10px;
433+
margin-bottom: 0px;
434434
}
435-
.newOperation img{
436-
vertical-align: center;
435+
436+
.newOperation img {
437+
vertical-align: center;
437438
}
438439

439440
.function-ul li {
@@ -483,13 +484,12 @@ a {
483484
font-weight: normal;
484485
}
485486

486-
.pageTitleNewItem h3
487-
{
487+
.newItem h3 {
488488
display: inline-block;
489489
}
490490

491-
.pageTitleNewItem img {
492-
margin: 0 0 10px 5px;
491+
.newItem img {
492+
margin: 0 0 10px 5px;
493493
}
494494

495495
.editorTitle {

0 commit comments

Comments
 (0)