Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Update GitHub Actions and Optimize Build Matrix #122

Merged
merged 10 commits into from
Feb 21, 2025

Conversation

hainaweiben
Copy link
Contributor

What do these changes do?

This PR includes several improvements to our GitHub Actions workflows:

  1. Updates all GitHub Actions to their latest stable versions:

    • actions/checkout: v3 -> v4
    • docker/setup-qemu-action: v2 -> v3
    • actions/upload-artifact: v3 -> v4
    • actions/download-artifact: v3 -> v4
    • microsoft/setup-msbuild: v2 -> v1.3.1
    • conda-incubator/setup-miniconda: v3 -> v4
    • pypa/gh-action-pypi-publish: v1.5.0 -> v1.8.11
  2. Optimizes build matrix configuration:

    • Adds platform-id for better build identification
    • Updates Python version format
    • Removes redundant configurations

Related issue number

Check code requirements

  • tests added / passed
  • Ensure all linting tests pass

1. Update actions to latest versions:
   - actions/checkout v3 -> v4
   - docker/setup-qemu-action v2 -> v3
   - actions/upload-artifact v3 -> v4
   - actions/download-artifact v3 -> v4
   - microsoft/setup-msbuild v2 -> v1.3.1
   - conda-incubator/setup-miniconda v3 -> v4
   - pypa/gh-action-pypi-publish v1.5.0 -> v1.8.11

2. Improve build matrix configuration:
   - Add platform-id for better identification
   - Update python version format
   - Remove redundant configurations

3. Update package name to test-xoscar for testing
@XprobeBot XprobeBot added this to the epic milestone Feb 12, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.65%. Comparing base (d6465c9) to head (3863ac4).
Report is 25 commits behind head on main.

❌ Your project status has failed because the head coverage (84.65%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   88.97%   84.65%   -4.33%     
==========================================
  Files          48       53       +5     
  Lines        4038     4660     +622     
  Branches      770      509     -261     
==========================================
+ Hits         3593     3945     +352     
- Misses        358      612     +254     
- Partials       87      103      +16     
Flag Coverage Δ
unittests 84.44% <ø> (-4.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qinxuye
Copy link
Contributor

qinxuye commented Feb 18, 2025

Is this ready to merge ? @luweizheng

@luweizheng
Copy link
Contributor

It works in xorbits, and I think it's ready to merge.

@luweizheng luweizheng changed the title Feat: Update GitHub Actions to Latest Versions and Optimize Build Matrix BLD: Update GitHub Actions to Latest Versions and Optimize Build Matrix Feb 18, 2025
@XprobeBot XprobeBot added build and removed feature labels Feb 18, 2025
@luweizheng luweizheng changed the title BLD: Update GitHub Actions to Latest Versions and Optimize Build Matrix BLD: Update GitHub Actions and Optimize Build Matrix Feb 18, 2025
Copy link
Contributor

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit 4df7631 into xorbitsai:main Feb 21, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants