Skip to content

Commit 2371256

Browse files
authored
Merge pull request alibaba#2185 from kfeagle/ios-feature-20170118
* [ios] bug fix: websocket module name is changed ,websocket used in playground should change
2 parents 00ca8aa + 860b44f commit 2371256

File tree

3 files changed

+29
-26
lines changed

3 files changed

+29
-26
lines changed

examples/module/websocket-demo.we

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
require('weex-components');
5858
var navigator = require('@weex-module/navigator');
5959
var modal = require('@weex-module/modal');
60-
var websocket = require('@weex-module/WebSocket');
60+
var websocket = require('@weex-module/webSocket');
6161
module.exports = {
6262
data: {
6363
connectinfo: '',

ios/sdk/WeexSDK/Sources/Component/WXTextAreaComponent.m

+22-17
Original file line numberDiff line numberDiff line change
@@ -156,17 +156,6 @@ - (instancetype)initWithRef:(NSString *)ref type:(NSString *)type styles:(NSDict
156156
if (styles[@"textAlign"]) {
157157
_textAlign = [WXConvert NSTextAlignment:styles[@"textAlign"]] ;
158158
}
159-
160-
_padding = UIEdgeInsetsZero;
161-
_border = UIEdgeInsetsZero;
162-
UIEdgeInsets padding = UIEdgeInsetsMake(self.cssNode->style.padding[CSS_TOP], self.cssNode->style.padding[CSS_LEFT], self.cssNode->style.padding[CSS_BOTTOM], self.cssNode->style.padding[CSS_RIGHT]);
163-
if (!UIEdgeInsetsEqualToEdgeInsets(padding, _padding)) {
164-
_padding = padding;
165-
}
166-
UIEdgeInsets border = UIEdgeInsetsMake(self.cssNode->style.border[CSS_TOP], self.cssNode->style.border[CSS_LEFT], self.cssNode->style.border[CSS_BOTTOM], self.cssNode->style.border[CSS_RIGHT]);
167-
if (!UIEdgeInsetsEqualToEdgeInsets(border, _border)) {
168-
_border = border;
169-
}
170159
}
171160

172161
return self;
@@ -229,8 +218,9 @@ - (void)viewDidLoad
229218
}
230219
[_textView setTextAlignment:_textAlign];
231220
[self setTextFont];
232-
[_textView setBorder:_border];
233-
[_textView setPadding:_padding];
221+
_padding = UIEdgeInsetsZero;
222+
_border = UIEdgeInsetsZero;
223+
[self updatePattern];
234224

235225
[_textView setNeedsDisplay];
236226
[_textView setClipsToBounds:YES];
@@ -251,6 +241,18 @@ -(void)blur
251241
}
252242
}
253243

244+
- (void)setPadding:(UIEdgeInsets)padding
245+
{
246+
_padding = padding;
247+
[_textView setPadding:padding];
248+
}
249+
250+
- (void)setBorder:(UIEdgeInsets)border
251+
{
252+
_border = border;
253+
[_textView setBorder:border];
254+
}
255+
254256
#pragma mark - add-remove Event
255257
- (void)addEvent:(NSString *)eventName
256258
{
@@ -349,16 +351,19 @@ - (void)updateStyles:(NSDictionary *)styles
349351
_placeholderColor = [UIColor colorWithRed:0x99/255.0 green:0x99/255.0 blue:0x99/255.0 alpha:1.0];
350352
}
351353
[self setPlaceholderAttributedString];
352-
354+
[self updatePattern];
355+
}
356+
357+
-(void)updatePattern
358+
{
353359
UIEdgeInsets padding = UIEdgeInsetsMake(self.cssNode->style.padding[CSS_TOP], self.cssNode->style.padding[CSS_LEFT], self.cssNode->style.padding[CSS_BOTTOM], self.cssNode->style.padding[CSS_RIGHT]);
354360
if (!UIEdgeInsetsEqualToEdgeInsets(padding, _padding)) {
355-
_padding = padding;
361+
[self setPadding:padding];
356362
}
357363

358364
UIEdgeInsets border = UIEdgeInsetsMake(self.cssNode->style.border[CSS_TOP], self.cssNode->style.border[CSS_LEFT], self.cssNode->style.border[CSS_BOTTOM], self.cssNode->style.border[CSS_RIGHT]);
359365
if (!UIEdgeInsetsEqualToEdgeInsets(border, _border)) {
360-
_border = border;
361-
[_textView setBorder:_border];
366+
[self setBorder:border];
362367
}
363368
}
364369

ios/sdk/WeexSDK/Sources/Component/WXTextInputComponent.m

+6-8
Original file line numberDiff line numberDiff line change
@@ -145,14 +145,6 @@ - (instancetype)initWithRef:(NSString *)ref type:(NSString *)type styles:(NSDict
145145
}else {
146146
_placeholderColor = [UIColor colorWithRed:0x99/255.0 green:0x99/255.0 blue:0x99/255.0 alpha:1.0];
147147
}
148-
UIEdgeInsets padding = UIEdgeInsetsMake(self.cssNode->style.padding[CSS_TOP], self.cssNode->style.padding[CSS_LEFT], self.cssNode->style.padding[CSS_BOTTOM], self.cssNode->style.padding[CSS_RIGHT]);
149-
if (!UIEdgeInsetsEqualToEdgeInsets(padding, _padding)) {
150-
[self setPadding:padding];
151-
}
152-
UIEdgeInsets border = UIEdgeInsetsMake(self.cssNode->style.border[CSS_TOP], self.cssNode->style.border[CSS_LEFT], self.cssNode->style.border[CSS_BOTTOM], self.cssNode->style.border[CSS_RIGHT]);
153-
if (!UIEdgeInsetsEqualToEdgeInsets(border, _border)) {
154-
[self setBorder:border];
155-
}
156148
}
157149

158150
return self;
@@ -184,6 +176,7 @@ - (void)viewDidLoad
184176
[_inputView setTextColor:_colorForStyle];
185177
[_inputView setText:_value];
186178
[_inputView setEnabled:!_disabled];
179+
[self updatePattern];
187180

188181
UIBarButtonItem *barButton = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemDone target:self action:@selector(closeKeyboard)];
189182
UIBarButtonItem *space = [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemFlexibleSpace target:nil action:nil];
@@ -319,7 +312,12 @@ - (void)updateStyles:(NSDictionary *)styles
319312
_placeholderColor = [UIColor colorWithRed:0x99/255.0 green:0x99/255.0 blue:0x99/255.0 alpha:1.0];
320313
}
321314
[self setPlaceholderAttributedString];
315+
[self updatePattern];
322316

317+
}
318+
319+
-(void)updatePattern
320+
{
323321
UIEdgeInsets padding = UIEdgeInsetsMake(self.cssNode->style.padding[CSS_TOP], self.cssNode->style.padding[CSS_LEFT], self.cssNode->style.padding[CSS_BOTTOM], self.cssNode->style.padding[CSS_RIGHT]);
324322
if (!UIEdgeInsetsEqualToEdgeInsets(padding, _padding)) {
325323
[self setPadding:padding];

0 commit comments

Comments
 (0)