Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following the C# changes as they go #180

Open
y-lohse opened this issue Jul 17, 2018 · 2 comments
Open

Following the C# changes as they go #180

y-lohse opened this issue Jul 17, 2018 · 2 comments

Comments

@y-lohse
Copy link
Owner

y-lohse commented Jul 17, 2018

One thing that made the v8 port painful was the amount of changes. I think it'd be a good idea to keep both codebases more in sync — it might be a bit more work if some commits undo each other, but at least that work will be spread out.

To do this, we should create a next branch to host the unpublished changes.

I also want to get automatic notifications when something changes on ink master. I had a quick look and couldn't find a github app for that, but running a hubot on a free zeit.co instance should do the job.

@joethephish
Copy link
Contributor

I'm in full support of this! However, aren't there 2 problems...?

  • In general, large quantities of changes to the C# codebase come in sudden flurries. We decide we need something, so I work on it full time for 1-2 weeks straight, creating a large set of changes.
  • And it depends on when you actually have the time to do the porting...?

@y-lohse
Copy link
Owner Author

y-lohse commented Jul 17, 2018

it depends on when you actually have the time to do the porting...?

Definitely, but I'm more likely to make time for it if there's a PR / issue open. I doubt we'll be constantly up to date, but hopefully we'll still reduce the backlog of changes to port. Having open issues also means other contributors are able to pick things up more easily.

In general, large quantities of changes to the C# codebase come in sudden flurries. We decide we need something, so I work on it full time for 1-2 weeks straight, creating a large set of changes.

For that "problem" I don't think there's a solution, but at least we can handle the large sets of changes one by one. It's still better than having to port changes to glue, pointers, profilers and other things all at once 😛 .
I know there aren't many small changes, but it also means we'd be able to handle those as we go, and have them out of the way of the bigger changesets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants