From d6459a4f87b36ede74f650e1c0d94cc5984b708b Mon Sep 17 00:00:00 2001 From: Mark Thomas Date: Wed, 5 Jul 2017 19:16:39 +0000 Subject: [PATCH] Use Map rather than a specific implementation git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1800915 13f79535-47bb-0310-9956-ffa450edef68 --- .../catalina/webresources/AbstractArchiveResourceSet.java | 5 ++--- .../webresources/AbstractSingleArchiveResourceSet.java | 3 ++- java/org/apache/catalina/webresources/JarWarResourceSet.java | 3 ++- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/java/org/apache/catalina/webresources/AbstractArchiveResourceSet.java b/java/org/apache/catalina/webresources/AbstractArchiveResourceSet.java index 4f6f4a0e889d..7243e649f116 100644 --- a/java/org/apache/catalina/webresources/AbstractArchiveResourceSet.java +++ b/java/org/apache/catalina/webresources/AbstractArchiveResourceSet.java @@ -21,7 +21,6 @@ import java.io.InputStream; import java.net.URL; import java.util.ArrayList; -import java.util.HashMap; import java.util.Map; import java.util.Set; import java.util.jar.JarEntry; @@ -38,7 +37,7 @@ public abstract class AbstractArchiveResourceSet extends AbstractResourceSet { private String baseUrlString; private JarFile archive = null; - protected HashMap archiveEntries = null; + protected Map archiveEntries = null; protected final Object archiveLock = new Object(); private long archiveUseCount = 0; @@ -174,7 +173,7 @@ public final Set listWebAppPaths(String path) { * @return The archives entries mapped to their names or null if * {@link #getArchiveEntry(String)} should be used. */ - protected abstract HashMap getArchiveEntries(boolean single); + protected abstract Map getArchiveEntries(boolean single); /** diff --git a/java/org/apache/catalina/webresources/AbstractSingleArchiveResourceSet.java b/java/org/apache/catalina/webresources/AbstractSingleArchiveResourceSet.java index 22578033c5bc..0d86ff9f9b0c 100644 --- a/java/org/apache/catalina/webresources/AbstractSingleArchiveResourceSet.java +++ b/java/org/apache/catalina/webresources/AbstractSingleArchiveResourceSet.java @@ -21,6 +21,7 @@ import java.net.MalformedURLException; import java.util.Enumeration; import java.util.HashMap; +import java.util.Map; import java.util.jar.JarEntry; import java.util.jar.JarFile; @@ -59,7 +60,7 @@ public AbstractSingleArchiveResourceSet(WebResourceRoot root, String webAppMount @Override - protected HashMap getArchiveEntries(boolean single) { + protected Map getArchiveEntries(boolean single) { synchronized (archiveLock) { if (archiveEntries == null && !single) { JarFile jarFile = null; diff --git a/java/org/apache/catalina/webresources/JarWarResourceSet.java b/java/org/apache/catalina/webresources/JarWarResourceSet.java index 805d8ddb4f0d..2bb2384cc265 100644 --- a/java/org/apache/catalina/webresources/JarWarResourceSet.java +++ b/java/org/apache/catalina/webresources/JarWarResourceSet.java @@ -21,6 +21,7 @@ import java.io.InputStream; import java.net.MalformedURLException; import java.util.HashMap; +import java.util.Map; import java.util.jar.JarEntry; import java.util.jar.JarFile; import java.util.jar.JarInputStream; @@ -94,7 +95,7 @@ protected WebResource createArchiveResource(JarEntry jarEntry, * returned. */ @Override - protected HashMap getArchiveEntries(boolean single) { + protected Map getArchiveEntries(boolean single) { synchronized (archiveLock) { if (archiveEntries == null) { JarFile warFile = null;