[YSQL] Failing PG15 Upgrade Tests #25620
Assignees
Labels
area/ysql
Yugabyte SQL (YSQL)
kind/enhancement
This is an enhancement of an existing feature
kind/failing-test
Tests and testing infra
priority/medium
Medium priority issue
Comments
timothy-e
added
area/ysql
yugabyte-ci
added
kind/failing-test
timothy-e
added a commit
that referenced
this issue
Jan 14, 2025
Summary: D41042 / ca6dfe4 broke some PG15 Online Upgrade tests. There are three distinct issues: 1. `check_loadable_libraries` was behind a `IsYugabyteEnabled()` in `check_new_cluster()`, but an earlier draft of D41042 removed the call to `check_new_cluster()` and cleaned up `check_new_cluster()` to leave it identical to vanilla PG. However, later versions of D41042 reintroduced the call to `check_new_cluster()` again, so `check_loadable_libraries()` was called. 2. `DatabaseWithDisallowedConnections` failed because it was asserting the stdout of `pg_upgrade`, which is no longer returned. 3. `UpgradeAuthEnabledUniverse` failed because of the precheck introduced by D41042. The way the precheck is called in the tests is not auth-aware. To re-enable this test sooner, create GHI #25621 to track testing the precheck for auth enabled universes. For now, just skip the precheck for auth-enabled universes. Jira: DB-14871 Test Plan: ``` ./yb_build.sh release --cxx-test integration-tests_pg15_upgrade-test --gtest_filter Pg15UpgradeTest.Template1 ./yb_build.sh release --cxx-test integration-tests_pg15_upgrade-test --gtest_filter Pg15UpgradeTestWithAuth.UpgradeAuthEnabledUniverse ./yb_build.sh release --cxx-test integration-tests_pg15_upgrade-test --gtest_filter Pg15UpgradeTest.DatabaseWithDisallowedConnections ``` Reviewers: hsunder Reviewed By: hsunder Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D41222
vpatibandla-yb
pushed a commit
that referenced
this issue
Jan 16, 2025
Summary: D41042 / ca6dfe4 broke some PG15 Online Upgrade tests. There are three distinct issues: 1. `check_loadable_libraries` was behind a `IsYugabyteEnabled()` in `check_new_cluster()`, but an earlier draft of D41042 removed the call to `check_new_cluster()` and cleaned up `check_new_cluster()` to leave it identical to vanilla PG. However, later versions of D41042 reintroduced the call to `check_new_cluster()` again, so `check_loadable_libraries()` was called. 2. `DatabaseWithDisallowedConnections` failed because it was asserting the stdout of `pg_upgrade`, which is no longer returned. 3. `UpgradeAuthEnabledUniverse` failed because of the precheck introduced by D41042. The way the precheck is called in the tests is not auth-aware. To re-enable this test sooner, create GHI #25621 to track testing the precheck for auth enabled universes. For now, just skip the precheck for auth-enabled universes. Jira: DB-14871 Test Plan: ``` ./yb_build.sh release --cxx-test integration-tests_pg15_upgrade-test --gtest_filter Pg15UpgradeTest.Template1 ./yb_build.sh release --cxx-test integration-tests_pg15_upgrade-test --gtest_filter Pg15UpgradeTestWithAuth.UpgradeAuthEnabledUniverse ./yb_build.sh release --cxx-test integration-tests_pg15_upgrade-test --gtest_filter Pg15UpgradeTest.DatabaseWithDisallowedConnections ``` Reviewers: hsunder Reviewed By: hsunder Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D41222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-14871
Description
failing since ca6dfe4
Issue Type
kind/failing-test
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: