Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typecheck the codebase #649

Open
immortal-tofu opened this issue Dec 11, 2024 · 0 comments
Open

Typecheck the codebase #649

immortal-tofu opened this issue Dec 11, 2024 · 0 comments
Assignees

Comments

@immortal-tofu
Copy link
Collaborator

immortal-tofu commented Dec 11, 2024

Following the PR #583 : The codebase is not typed correctly, we have a lot of errors to fix.

npx tsc --noEmit

Found 571 errors in 33 files.

Errors  Files
     1  hardhat.config.ts:21
     1  node_modules/@openzeppelin/hardhat-upgrades/dist/upgrade-proxy.d.ts:5
     1  node_modules/@openzeppelin/upgrades-core/dist/upgrade-interface-version.d.ts:2
     2  node_modules/@types/glob/index.d.ts:29
     3  tasks/taskDeploy.ts:161
     1  tasks/taskGatewayRelayer.ts:118
    19  test/asyncDecrypt.ts:55
    12  test/blindAuction/BlindAuction.ts:20
   324  test/coprocessorUtils.ts:34
     2  test/encryptedERC20/EncryptedERC20.FHEGas.ts:40
    10  test/fhevmjsMocked.ts:8
    10  test/identity/compliantERC20.ts:26
     4  test/identity/identityRegistry.ts:18
     3  test/instance.ts:8
    12  test/payments/payments.ts:24
    11  test/rand/Rand.ts:56
     2  test/regressions/Regression1.ts:6
     5  test/signers.ts:41
     1  test/tfheOperations/manual.ts:4
    11  test/tfheOperations/tfheOperations1.ts:4
    11  test/tfheOperations/tfheOperations10.ts:4
    11  test/tfheOperations/tfheOperations11.ts:4
    11  test/tfheOperations/tfheOperations12.ts:4
    11  test/tfheOperations/tfheOperations13.ts:4
    11  test/tfheOperations/tfheOperations2.ts:4
    11  test/tfheOperations/tfheOperations3.ts:4
    11  test/tfheOperations/tfheOperations4.ts:4
    11  test/tfheOperations/tfheOperations5.ts:4
    11  test/tfheOperations/tfheOperations6.ts:4
    11  test/tfheOperations/tfheOperations7.ts:4
    11  test/tfheOperations/tfheOperations8.ts:4
    11  test/tfheOperations/tfheOperations9.ts:4
     4  test/types.ts:1

Edit by @bcm-at-zama : it's an explicit request by Inco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants