Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read standard environment variables for host, user & token #233

Open
claytonrcarter opened this issue Nov 5, 2018 · 2 comments
Open

Read standard environment variables for host, user & token #233

claytonrcarter opened this issue Nov 5, 2018 · 2 comments

Comments

@claytonrcarter
Copy link
Collaborator

claytonrcarter commented Nov 5, 2018

I'm new to go, but excited about this utility. Thanks for creating it!

I was reading the config code and it a looks like lab will use LAB_CORE_HOST, ..._USER and ..._TOKEN when launching. I can't find specific documentation at GitLab about this, but a number of other projects use the GITLAB_API_ENDPOINT and GITLAB_API_PRIVATE_TOKEN variables for this. (GITLAB_API_USER seems less common, but could also be used.)

What do you think about having lab read these variables as well?

@claytonrcarter
Copy link
Collaborator Author

Actually, I did some more research and it looks like GITLAB_USER_LOGIN has been in CI used since GL 10 to hold "The login username of the user who started the job" (https://docs.gitlab.com/ee/ci/variables/) and might be an already-supported-but-not-for-this-exact-use-case variable.

@zaquestion
Copy link
Owner

Very open to suggestions here and on the overall config format. I'm planning to give the whole thing an overhaul for 1.0

Mainly to support #151 -- I'm inclined to hold off on more environment variables until then, since it may change things, but I don't feel strongly about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants