From 94539396ab6d8ccb4ddba3d0625663b5efbb98cf Mon Sep 17 00:00:00 2001 From: Chris Seto Date: Wed, 23 Aug 2023 17:49:05 +0000 Subject: [PATCH] build: explicitly set SKIP_LABEL_TEST_FAILURE in compose.sh Previously, `SKIP_LABEL_TEST_FAILURE` was being set via a teamcity configuration. This change was quite opaque as the majority of CI configuration for Cockroach is stored as shell scripts within its repo. This commit follows that pattern by explicitly setting `SKIP_LABEL_TEST_FAILURE` in the script that runs `TestComposeCompare`. Epic: None Release note: None --- build/teamcity/cockroach/nightlies/compose.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/build/teamcity/cockroach/nightlies/compose.sh b/build/teamcity/cockroach/nightlies/compose.sh index e6a775f79362..8f3bfbdbefdc 100755 --- a/build/teamcity/cockroach/nightlies/compose.sh +++ b/build/teamcity/cockroach/nightlies/compose.sh @@ -6,6 +6,12 @@ dir="$(dirname $(dirname $(dirname $(dirname "${0}"))))" source "$dir/teamcity-support.sh" source "$dir/teamcity-bazel-support.sh" +# The test failures generated by TestComposeCompare are not necessarily +# failures per se. They're cases of behavioral divergences from Postgres. While +# our compatibility guarantees are not 100%, it's better to treat failures as +# information to occasionally review. +export SKIP_LABEL_TEST_FAILURE=1 + tc_start_block "Run compose tests" bazel build //pkg/cmd/bazci --config=ci