From 3b677c10c9785d9fdc85e40a34d41529d253a6be Mon Sep 17 00:00:00 2001
From: Benjamin Bannier <benjamin.bannier@corelight.com>
Date: Fri, 10 Jan 2025 08:04:25 +0100
Subject: [PATCH] Address a FIXME.

I believe the issue documented in the FIXME was a problem with some
older stdlib implementation/compiler versions. Drop it since it seems to
work fine now.
---
 hilti/toolchain/src/base/util.cc | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hilti/toolchain/src/base/util.cc b/hilti/toolchain/src/base/util.cc
index 18ae294ce..8202372ed 100644
--- a/hilti/toolchain/src/base/util.cc
+++ b/hilti/toolchain/src/base/util.cc
@@ -45,9 +45,7 @@ std::vector<std::string> util::split(std::string s, const std::string& delim) {
 
         l.push_back(s.substr(0, p));
 
-        // FIXME: Don't understand why directly assigning to s doesn't work.
-        std::string t = s.substr(p + delim.size(), std::string::npos);
-        s = std::move(t);
+        s = s.substr(p + delim.size(), std::string::npos);
     }
 
     l.push_back(s);