Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getters to private properties, re: #148 #150

Open
wants to merge 6 commits into
base: 1.x
Choose a base branch
from
Open

add getters to private properties, re: #148 #150

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2770c47
add getters to private properties, re: #148
tacman Jun 10, 2024
659625b
add setters for directories
tacman Jun 10, 2024
0f40714
add simple tests for directory setter/getters
tacman Jun 10, 2024
a93dc82
Update src/Browser/PantherBrowser.php
tacman Jul 22, 2024
7862fc4
use self::assertSame()
tacman Jul 22, 2024
df3f3c9
Merge branch 'zenstruck:1.x' into 1.x
tacman Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add simple tests for directory setter/getters
  • Loading branch information
@tacman
tacman committed Jun 10, 2024
commit 0f407143f9c65da150c3e1cadcba9a5489b65fb0
12 changes: 12 additions & 0 deletions tests/PantherBrowserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,18 @@ public function can_use_panther_browser_as_typehint(): void
;
}

/**
* @test
*/
public function can_configure_directories(): void
{
$this->browser()->setScreenshotDir($screenshotDir = '/path/to/screenshot');
assert($this->browser()->getScreenshotDir() === $screenshotDir);

$this->browser()->setConsoleLogDir($logDir = '/path/to/consoleLogs');
assert($this->browser()->getScreenshotDir() === $logDir);
}

/**
* @test
*/
Expand Down
Loading