Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VT analytic #12

Open
Rosadosa opened this issue Jan 30, 2017 · 3 comments
Open

VT analytic #12

Rosadosa opened this issue Jan 30, 2017 · 3 comments

Comments

@Rosadosa
Copy link

Hi Zhanxw,

thank you for your very valuable tool!
I have a question regarding the Variable threshold analytic option.
In the manual it is stated this option supports both binary and quantitative phenotypes.
However when I try to run the analysis, a warning appears that the analytic option doesn't work on a binary phenotype, and all my values are "NA".

Is this merely a mistake in the manual, or is there something else going on?

Best,
Roos

@zhanxw
Copy link
Owner

zhanxw commented Jan 31, 2017

Thanks Roos.
I can replicate the problem.

The VT analytic option should work. I will fix this bug.

@zhanxw zhanxw added the bug label Jan 31, 2017
@zhanxw zhanxw added enhancement and removed bug labels Feb 10, 2017
@zhanxw
Copy link
Owner

zhanxw commented Feb 10, 2017

From source code,
https://github.com/zhanxw/rvtests/blob/master/src/Model.h#L2132,
It looks like that I have not implemented the analytic VT method for binary trait.
I plan to do it when I have more time.

@learb
Copy link

learb commented Nov 14, 2018

Hi Zhanxw,

thank you for this really valuable tool!
I see you had in mind to implement analytic VT for binary trait, but I still get the error described here. Is this still an enhancement you are considering? do you have a work-around?

Thanks
Lea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants