Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to VideoDataLayer break test cases for C3D #27

Closed
Multihuntr opened this issue Nov 29, 2017 · 1 comment
Closed

Changes to VideoDataLayer break test cases for C3D #27

Multihuntr opened this issue Nov 29, 2017 · 1 comment

Comments

@Multihuntr
Copy link

This repository just instructs users to follow the C3D installation instructions, and as part of those instructions it tells users to run make runtest to ensure it has been installed correctly. The edits made to the C3D implementations break the test cases and since there was no mention of this in this repository it is very misleading. i.e. it suggests that C3D has not been installed correctly.

Can you either fix the test cases or put a note into the README.md in this repo's root mentioning that the test cases for VideoDataLayer are expected to fail?
@zhengshou
Copy link
Owner

Thanks much for the heads-up. Will update readme file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Multihuntr @zhengshou