Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Client Assertion token request includes basic auth header #453

Closed
1 of 2 tasks
Kunde21 opened this issue Oct 4, 2023 · 3 comments
Closed
1 of 2 tasks

[Bug]: Client Assertion token request includes basic auth header #453

Kunde21 opened this issue Oct 4, 2023 · 3 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@Kunde21
Copy link

Kunde21 commented Oct 4, 2023

Preflight Checklist

  • I could not find a solution in the documentation, the existing issues or discussions
  • I have joined the ZITADEL chat

Version

v2.11.0

Describe the problem caused by this bug

Using a relying party client with JWTProfile configured as the client authentication, code exchange requests include both client_assertion=<jwt payload> form value and one of Authorization: Basic <id:secret> header or client_id=<id>&client_secret=<secret> form values.

To reproduce

Create a relying party with the WithJWTProfile option, attempt a token exchange, inspect the request headers/body.

Screenshots

No response

Expected behavior

Support the JWT Profile oidc client authentication without overlapping with additional client authentication methods.

Additional Context

By the look of things, this is a result of the golang.org/x/oauth2 library forcing client basic or client post authentication without allowing for client assertion approaches.

@Kunde21 Kunde21 added the bug Something isn't working label Oct 4, 2023
@muhlemmer
Copy link
Collaborator

It seems indeed golang.org/x/oauth2 does that and we don't have much control over it. I also went through the code to see if there is a way around, but found none. You should create an issue upstream.

@muhlemmer muhlemmer added the wontfix This will not be worked on label Oct 13, 2023
@Kunde21
Copy link
Author

Kunde21 commented Oct 17, 2023

golang/oauth2#433

@hifabienne
Copy link
Member

I will close this issue for now, as we will not implement something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants