Skip to content

Commit 378704c

Browse files
authoredMar 12, 2022
Fix rocksdb cmake depends should use list instead of string (apache#518)
1 parent e3da57d commit 378704c

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed
 

‎README.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,9 @@ Kvrocks has the following key features:
5353
# Centos/Redhat
5454
sudo yum install -y epel-release && sudo yum install -y git gcc gcc-c++ make snappy snappy-devel autoconf automake libtool which gtest gtest-devel
5555

56-
# Ubuntu
57-
sudo apt-get install gcc g++ make libsnappy-dev autoconf automake libtool which libgtest-dev
56+
# Ubuntu/Debian
57+
sudo apt update
58+
sudo apt-get install gcc g++ make libsnappy-dev autoconf automake libtool
5859

5960
# MACOSX
6061
brew install autoconf automake libtool snappy googletest

‎cmake/rocksdb.cmake

+2-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ if (NOT __ROCKSDB_INCLUDED)
1616
set(ROCKSDB_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${ROCKSDB_EXTRA_COMPILER_FLAGS}")
1717
set(ROCKSDB_C_FLAGS "${CMAKE_C_FLAGS} ${ROCKSDB_EXTRA_COMPILER_FLAGS}")
1818
if (NOT DISABLE_JEMALLOC)
19-
set(ROCKSDB_DEPENDS "jemalloc snappy")
19+
list(APPEND rocksdb_DEPENDS jemalloc)
20+
list(APPEND rocksdb_DEPENDS snappy)
2021
set(JEMALLOC_ROOT_DIR ${jemalloc_INSTALL})
2122
else()
2223
set(rocksdb_DEPENDS "snappy")

0 commit comments

Comments
 (0)
Please sign in to comment.