Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIRTUAL_HOST needs to be decoupled from LETSENCRYPT_HOST #991

Open
futhrevo opened this issue Aug 6, 2018 · 0 comments
Open

VIRTUAL_HOST needs to be decoupled from LETSENCRYPT_HOST #991

futhrevo opened this issue Aug 6, 2018 · 0 comments

Comments

@futhrevo
Copy link

futhrevo commented Aug 6, 2018

Mup version (mup --version): 1.4.5

VIRTUAL_HOST needs to be decoupled from LETSENCRYPT_HOST so that we see a consistent url in address bar

Where is VIRTUAL_HOST used?
For configuring jwilder/nginx-proxy

Why is VIRTUAL_HOST used?
jwilder/nginx-proxy uses this environment variable to create default.conf rules

Please refer: https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Choosing_between_www_and_non-www_URLs

Current Behaviour: mup constructs VIRTUAL_HOST based on proxy.domains. Nginx creates rules that are inconsistent with domain redirect. Consider a scenario where proxy.domains contain both non-www and www. Now Nginx constructs server blocks separately for non-www and www. Now https://example.com and https://www.example.com becomes valid. Presently it is impossible to override Nginx default.conf with shared proxy config

Expected Behaviour: separating HOST enable user to use redirect method in Nginx for a single canonical name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants